search

echasnovski / mini.nvim

Library of 40+ independent Lua modules improving overall Neovim (version 0.8 and higher) experience with minimal effort
MIT License
4.47k stars 175 forks source link

Don't set terminal colors in base16 #899

Closed arcxio closed 1 month ago

arcxio commented 1 month ago

Contributing guidelines

Module(s)

mini.base16

Description

mini.base16 overrides terminal colors with a supplied palette, which results in different colors in a neovim terminal than the ones configured in a terminal emulator: image What is the reason for this? I believe there should at least be an option to turn this behavior off, as I found it jarring: neovim terminal isn't expected to have its own colors

echasnovski commented 1 month ago

What is the reason for this? I believe there should at least be an option to turn this behavior off, as I found it jarring: neovim terminal isn't expected to have its own colors

The reason for this is because I believe every buffer inside Neovim is expected to use colors from color scheme. If you don't want them, I'd suggest unsetting vim.g.terminal_color_x variables. Like vim.g.terminal_color_0 = nil, and make sure to do that after require('mini.base16').setup().

Closing as both "works as expected" and "not planned".