search

echasnovski / mini.nvim

Library of 40+ independent Lua modules improving overall Neovim (version 0.8 and higher) experience with minimal effort
MIT License
4.47k stars 175 forks source link

feat(completion): add icons to suggestions #913

Closed Sookhaal closed 1 month ago

Sookhaal commented 1 month ago

image Screenshot 2024-05-25 132304

I'd like to add colors to the icons and kind text as well, but couldn't figure out how.

The default icons are taken from https://code.visualstudio.com/docs/editor/intellisense#_types-of-completions and require a nerd font to be seen properly.

Bear with me, this is my first time doing anything nvim plugin related!

echasnovski commented 1 month ago

Thanks for the PR!

Bear with me, this is my first time doing anything nvim plugin related!

I am sorry to have the following answer, but this (icons in 'mini.completion' suggestions) is currently out of scope. It is intentional to reduce config complexity and improve performance (without much caching going on).

I strongly ask to create an issue first before creating a PR, so that to not have your time wasted on functionality that won't be merged.

Closing as (yet) not planned.

That said, I do have quite immediate plans for some kind of unified icons integration in 'mini.nvim'. After those are implemented, 'mini.completion' might get icons (but not guaranteed).

Sookhaal commented 1 month ago

Sounds good! I've learned a lot along the way while searching about how to do this PR, so it was worth it anyway.

Thank you for the hard work on those plugins, and thanks for the quick feedback!