search

echasnovski / mini.nvim

Library of 40+ independent Lua modules improving overall Neovim (version 0.8 and higher) experience with minimal effort
MIT License
4.45k stars 171 forks source link

mini.pick issues with file paths containing ':' #954

Open jason0x43 opened 3 weeks ago

jason0x43 commented 3 weeks ago

Contributing guidelines

Module(s)

mini.pick, mini.extra

Description

Neither the files picker nor the git_files picker show icons for file paths containing ':'. The git_files picker also doesn't open files containing ':' (similar to #714).

Neovim version

0.10.0

Steps to reproduce

  1. Create a git repo and add a file file named Feb_16_2024_10:40_PM.py
  2. Open nvim and call MiniExtra.pickers.git_files()
  3. If devicons are setup, note that Feb_16_2024_10:40_PM.py doesn't have an icon
  4. Choose Feb_16_2024_10:40_PM.py
  5. Note that the file is not opened

Expected behavior

A file with a name containing a ':' should work the same as any other file (it should have the proper icon in the picker and should open when actioned).

Actual behavior

A file with a name containing a ':' does not have an icon and does not open when actioned.

2024-06-09 09 17 56

echasnovski commented 3 weeks ago

Thanks for the issue!

I can reproduce both. The git_files might get the same treatment as files picker after #714.

Regarding icon, I'll take a look.