search

echawk / kiss-xorg

A KISS Linux Repository for Xorg
MIT License
34 stars 9 forks source link

ffmpeg won't build with vulkan present #127

Closed davidgarland closed 1 year ago

davidgarland commented 1 year ago

This is admittedly a problem that won't affect 99% of users since Vulkan isn't something widely packaged on KISS, but it is available via sewn's gkiss-multilib repo.

I found a thread here that describes the issue where they link this patch which deletes the offending lines. In the thread, they clarify that these features aren't yet used within ffmpeg (as of 25 Dec 2022) and that doing a patch to change the names to the proper ones seems like a bad idea from their POV.

I've tried the patch myself and can confirm it works; if you'd be interested in me adding it here then I'd be happy to make a PR (and if not, I understand why). It's probably the case that some future version of ffmpeg will start to depend on these lines and get the identifiers' names right, at which point the patch could be removed.

Another much simpler option would be to just disable Vulkan support outright by just adding --disable-vulkan to the build config, which is what it seems sewn did. Then, likewise, we could just remove this flag when ffmpeg's Vulkan support is more mature.

apprehensions commented 1 year ago

Vulkan is not handled by kiss-xorg, and neither is there any Vulkan support on most applications. Why is the issue being made here? The only time i expected Vulkan working is when i was trying to run SuperTuxKart, as it ran with the more inferior OpenGL. Who knows, maybe Vulkan will one time be pushed here and maintained by me???

davidgarland commented 1 year ago

Why is the issue being made here?

Because it's an issue with ffmpeg, not with any other package. I mean, doing an override is possible (and is what I am doing, evidently, so this isn't a showstopper by any means) but it seems "nicer" to just have one package maintained that works for everyone. If practically no-one uses vulkan, and those who do use vulkan need it disabled on ffmpeg, then I think adding the --disable-vulkan option has no potential downsides.

OTOH because it's such a minor issue it's also perfectly fair to say it's not worth fixing and just drop the issue. I don't mind either way but just thought I'd bring this to light to attempt to reduce duplication of work.

davidgarland commented 1 year ago

Actually, it may be a moot point because I've just realized FFmpeg 6.0 released 6 days ago, and that patch seems to fall under that tag. It may suffice to just bump the package to that, assuming it doesn't turn out to break anything-- I'll give it a spin tomorrow morning and see if it all works, and if so I'll make a PR for it.

davidgarland commented 1 year ago

I'll close this, as a solution through #128 will work in the future (somewhere in April, most likely)