search

echawk / kiss-xorg

A KISS Linux Repository for Xorg
MIT License
34 stars 9 forks source link

libpciaccess: fix pread64 and pwrite64 issues #138

Closed hovercats closed 1 year ago

hovercats commented 1 year ago

so, libpciaccess uses pwrite64 and pread64, both of which gcc complains about being deprecated. initially users should be able to just ignore these as just warnings, unless the selective werror configure check wont flag any of them as errors for you. which seems to be the case for me.

I tried to add --disable-selective-werror as configure flags to bypass this, but it errors out on missing references instead.

adding the seds to instead use pread and pwrite as opposed to pread64 and pwrite64 fixes the issue.

apprehensions commented 1 year ago

Why not add this to upstream?

hovercats commented 1 year ago

pr upstream here

echawk commented 1 year ago

LGTM