search

echebbi / eclipse-discord-integration

Discord's Rich Presence Integration within Eclipse IDE
https://discord-rich-presence-for-eclipse-ide.readthedocs.io/en/latest/
Other
45 stars 5 forks source link

Doesn't seem to work for me (Win10 1803) #56

Closed Derkades closed 5 years ago

Derkades commented 5 years ago

Added game manually in game activity menu, does show up but no RP image

Using the default settings image

Enabled in startup image

Using eclipse Oxygen image

Windows 10 1803 image

Clem-Fern commented 5 years ago

Same for me with Eclipse 2018-09 (4.9.0) Build id: 20180917-1800 and Windows 10 (1803)

echebbi commented 5 years ago

I cannot reproduce this issue: on my Windows 10 the plug-in works with both Eclipse IDE 4.7 and 4.9. Could you open the Error Log view (Window > Show View > Other... > Error Log) and check whether any log seems related to the plug-in ? The name in the Plug-in column should start with fr.kazejiyu.discord.

Clem-Fern commented 5 years ago

Nothing related with your plugin in my error log.

Derkades commented 5 years ago

I see the following error in my error log from fr.kazejiyu.discord.rpc.integration:

org.eclipse.core.internal.resources.ResourceException: Project 'Discord Bot' is not open.
    at org.eclipse.core.internal.resources.Project.checkAccessible(Project.java:144)
    at org.eclipse.core.internal.resources.Resource.checkAccessibleAndLocal(Resource.java:215)
    at org.eclipse.core.internal.resources.Resource.getPersistentProperty(Resource.java:1125)
    at fr.kazejiyu.discord.rpc.integration.ui.preferences.properties.ProjectPropertiesPage.setMissingPropertiesToDefault(ProjectPropertiesPage.java:131)
    at fr.kazejiyu.discord.rpc.integration.ui.preferences.properties.ProjectPropertiesPage.createContents(ProjectPropertiesPage.java:84)
    at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:241)
    at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1426)
    at org.eclipse.jface.preference.PreferenceDialog$8.run(PreferenceDialog.java:1193)
    at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    at org.eclipse.ui.internal.JFaceUtil.lambda$0(JFaceUtil.java:44)

Discord Bot is one of many projects in my workspace, and as the error message says, I have closed it. Does this software handle closed projects properly?

echebbi commented 5 years ago

@Derkades the plug-in is not disturbed by closed projects. Your error has likely been logged when you checked the Properties of your closed project. I'll handle this case in a better way in the future but it cannot be the source of the failure, and besides, I successfully managed to use the plug-in in a workspace containing several closed projects.

I will deploy a new release embedding a debug mode which should help me to find out what the problem is.

Clem-Fern commented 5 years ago

I do not have the problem anymore and I have neither change the version of eclipse, nor that of windows. So it's ok for me

OmgItzValk commented 5 years ago

@Clem-Fern I still have your problem but I'm confused because I don't have any errors, you sure you did nothing?

echebbi commented 5 years ago

If no error is reported to the Error Log then problem might come from Discord RCP's SDK ; the incoming debug mode should allow me to determine this more easily.

I do not have the time to work on it right now but it should be done by Sunday.

Derkades commented 5 years ago

I had to reinstall Windows because my installation got corrupt. Also reinstalled eclipse and this plugin, and it worked. I'm not sure which of the three fixed it though

echebbi commented 5 years ago

Thank you for the feedback, I am happy to know that the issue is fixed for you! Sadly I really don't have the time to work on this project at the moment so I cannot help the others.

SkytAsul commented 5 years ago

I'm having the same problem : nothing in Error Log, using the latest version... Do you think that comes from the using of the beta version of Discord ? (Discord PTB)

echebbi commented 5 years ago

It is a possibility, but I don't think so. I am still very busy but I will try to release as soon as possible a new version embedding more debug logs and the latest version of java-discord-rcp (the library I used to interact with Discord) which should help to fix the issue.

echebbi commented 5 years ago

So I finally took the time to add some logs. I deployed a new (unofficial) 1.0.2 version that can be downloaded from https://dl.bintray.com/kazejiyu/eclipse-discord-integration/snapshots/1.0.2 (with Help > Install new software...).

This version embeds a new "debug mode". This mode can be activated from the preferences (Window > Preferences > Discord Rich Presence):

image

Once this mode is activated you have to open the Error Log view (Window > Show View > Other... > Error Log). You should then see a bunch of logs being written as you open new files:

image

All these logs can be exported in a single .log file by pressing the "Export Log" button on the top right corner of the view. You can use it to share them with me. I hope it will help to find the cause of the issue.

This version also embeds the last java-discord-rpc, so it might fix the issue.

SkytAsul commented 5 years ago

Nice it works !! Even on Discord PTB + BetterDiscord 😄 Thank you !

echebbi commented 5 years ago

I'm glad to know it! I'll keep the issue opened until an official release is deployed.

echebbi commented 5 years ago

Should be fixed as of the new 1.0.3 release. Please leave a comment if on this thread if that's not the case so that I can re-open the issue.