echebbi / eclipse-discord-integration

Discord's Rich Presence Integration within Eclipse IDE
https://discord-rich-presence-for-eclipse-ide.readthedocs.io/en/latest/
Other
45 stars 5 forks source link

Allow users to use their own Discord application (fix #66) #69

Closed echebbi closed 5 years ago

echebbi commented 5 years ago

Allows users to change the icon and the name of the game shown in Discord (fix #66).

Both IDE and project preferences pages have been enhanced with a new "Icons" subsection to allow the use a custom Discord application ID:

New Preferences page

New Project Settings page

Moreover, a part of the core have been refactored

codecov[bot] commented 5 years ago

Codecov Report

Merging #69 into master will decrease coverage by 2.24%. The diff coverage is 70.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
- Coverage     74.92%   72.67%   -2.25%     
- Complexity      200      207       +7     
============================================
  Files            23       25       +2     
  Lines           630      732     +102     
  Branches         62       78      +16     
============================================
+ Hits            472      532      +60     
- Misses          145      179      +34     
- Partials         13       21       +8
Impacted Files Coverage Δ Complexity Δ
...u/discord/rpc/integration/core/SelectionTimes.java 100% <ø> (ø) 8 <0> (ø) :arrow_down:
...ntegration/extensions/EditorInputRichPresence.java 100% <ø> (ø) 1 <0> (ø) :arrow_down:
.../discord/rpc/integration/files/OnPostShutdown.java 0% <ø> (ø) 0 <0> (?)
...rd/rpc/integration/core/PreferredRichPresence.java 100% <ø> (ø) 11 <0> (ø) :arrow_down:
...c/integration/files/AddListenerOnWindowOpened.java 100% <ø> (ø) 11 <0> (?)
...cord/rpc/integration/core/DiscordRpcLifecycle.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../discord/rpc/integration/core/DiscordRpcProxy.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...tegration/settings/ProjectPreferencesListener.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...d/rpc/integration/settings/ProjectPreferences.java 0% <0%> (-7.15%) 0 <0> (-1)
...iyu/discord/rpc/integration/settings/Settings.java 97.22% <100%> (+1.98%) 5 <2> (ø) :arrow_down:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2aba8c0...1fea890. Read the comment docs.

echebbi commented 5 years ago

I sadly don't have enough free time to write as much tests as I'd like and this feature is waiting for a long time, so let's just merge now.