search

echebbi / eclipse-discord-integration

Discord's Rich Presence Integration within Eclipse IDE
https://discord-rich-presence-for-eclipse-ide.readthedocs.io/en/latest/
Other
45 stars 5 forks source link

Prevent custom project names from being ignored #79

Closed echebbi closed 4 years ago

echebbi commented 4 years ago

I have been a bit too quick merging #78; this PR fixes a regression preventing custom project names from being ignored.

I bump the version to 1.2.0 because #78 introduced a new feature and should have incremented the 'minor' version.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

codecov[bot] commented 4 years ago

Codecov Report

Merging #79 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #79   +/-   ##
=========================================
  Coverage     69.67%   69.67%           
  Complexity      227      227           
=========================================
  Files            25       25           
  Lines           821      821           
  Branches        103      103           
=========================================
  Hits            572      572           
  Misses          224      224           
  Partials         25       25
Impacted Files Coverage Δ Complexity Δ
...n/adapters/DefaultFileEditorInputRichPresence.java 95.91% <100.00%> (ø) 25.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0ee5ef...de21381. Read the comment docs.