search

echemdata / galvani

Read proprietary file formats from electrochemical test stations
GNU General Public License v3.0
47 stars 30 forks source link

Add more column types to BioLogic.py #71

Closed chatcannon closed 1 year ago

chatcannon commented 2 years ago

This was created as https://github.com/chatcannon/galvani/pull/1 by @GhostDeini and has been moved to the main repo.

Added "control/mA", "Q charge/discharge/mA.h", "step time/s", "Q charge/mA.h", "Q discharge/mA.h", "Efficiency/%", "Capacity/mA.h" to possible fieldnames in fieldname_to_dtype(fieldname). Also in VMPdata_colID_dtype_map.

chatcannon commented 2 years ago

@GhostDeini Do you have any example data files which include these columns?

JhonFlash3008 commented 9 months ago

Hey ! I'm working on trying to import all kinds of mprfiles in order to spot the possible errors and particularly the missing col IDs. I compare the mpr files with their mpt extract in order to do so. I found these ones in particular :

498: ("|Ece h2|/V", "<f4"),
 499: ("|Ece h3|/V", "<f4"),
 500: ("|Ece h4|/V", "<f4"),
 501: ("|Ece h5|/V", "<f4"),
 502: ("|Ece h6|/V", "<f4"),
 503: ("|Ece h7|/V", "<f4"),

But they already had a corresponding ID :

    499: ('Q discharge/mA.h', '<f8'),
    500: ('step time/s', '<f8'),
    501: ('Efficiency/%', '<f8'),
    502: ('Capacity/mA.h', '<f8')

I wasn't sure if it was ok to replace the existing ones but apparently they were added with this merge and do not have a specific example file ?

chatcannon commented 8 months ago

I wasn't sure if it was ok to replace the existing ones but apparently they were added with this merge and do not have a specific example file ?

If they don't have an example file and yours do then let's go with your version. I don't have any other way of verifying it myself.