echen831 / Robbyhood

1 stars 1 forks source link

User Auth #1

Closed echen831 closed 4 years ago

echen831 commented 4 years ago

User Auth

Functionality

Before Login

After Login

Style

Seeds

ronilbhatia commented 4 years ago

Hey Eric, good job! Here are my comments:

  1. Try to match the styling of Robinhood closer on the session form. Center the form vertically on the page. Make the input boxes a little lighter and maybe get rid of the default border they have, only adding one on hover/focus. The input boxes and buttons should not change size when hovered over (you probably need to set box-sizing: border-box in your CSS reset file). Add cursor: pointer to the buttons as well. Render the error messages below the input boxes so it doesn't cause things to move around on the page, and make them a bolder font. Screen Shot 2020-04-30 at 3 56 29 PM Screen Shot 2020-04-30 at 3 56 36 PM

  2. Right now pressing enter on the form submits with the 'Demo User' data, even if I'm on the sign up form which doesn't have a demo user button.

  3. Remove your Redux logger/console logs from production