Closed echen831 closed 4 years ago
Hey Eric, good job! Here are my comments:
Try to match the styling of Robinhood closer on the session form. Center the form vertically on the page. Make the input boxes a little lighter and maybe get rid of the default border they have, only adding one on hover/focus. The input boxes and buttons should not change size when hovered over (you probably need to set box-sizing: border-box
in your CSS reset file). Add cursor: pointer
to the buttons as well. Render the error messages below the input boxes so it doesn't cause things to move around on the page, and make them a bolder font.
Right now pressing enter on the form submits with the 'Demo User' data, even if I'm on the sign up form which doesn't have a demo user button.
Remove your Redux logger/console logs from production
User Auth
Functionality
/
Before Login
/login
page should not display a link toLog In
. Same for/signup
/#/oweiniouewbrviuwebv
should redirect or display a 404 page/signup
and/login
./signup
and/login
.After Login
/login
or/signup
Style
cursor: pointer
on hoverSeeds