echo-crew / sana.protocol_builder

Web app for building Sana Protocols

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

Import xml protocols #6

Closed j449li closed 7 years ago

j449li commented 7 years ago

Test plan:

created procedure -> downloaded procedure -> imported the downloaded procedure
successfully imported https://github.com/SanaMobile/sana.mobile/blob/master/app/src/main/res/raw/surgery.xml
successfully imported https://github.com/SanaMobile/sana.mobile/blob/master/app/src/main/res/raw/derma.xml

j449li commented 7 years ago

@dsu1995 Your suggestion is a preferred way of doing things in Python, but it's not appealing in this context. It's redundant to split the functions of each class into a separate module, since they don't make sense by themselves and will not be used outside of ProtocolImporter. Splitting it up only adds more maintenance overhead.

xjie11 commented 6 years ago