search

echo-swent / echo

4 stars 0 forks source link

Fix app crash when register with an existing account #289

Closed octogradiste closed 4 months ago

octogradiste commented 4 months ago

The crash was due to the fact that the registering was successful, but didn't save the userId locally. To do so, we must request a login from the user. Only then the userId will be saved.

octogradiste commented 4 months ago

Thanks for the review!

We are redirected in the login screen with the message "confirm your email to continue". It would be better to add an error case "email already used".

I'll have to investigate that. I know it's confusing to the user, but I'm not sure if I can get this information somewhere. As this is only a rare case (user tries to register with an existing account) I thought this solution was acceptable.

Then, if we create a new account and reach the profile creation, clicking on the back button will just reload the profile creation screen.

This is something we should address in another PR. Actually, this shouldn't be very hard, change the back button to log the user out and navigate to the login screen. Or we simply drop the back button... why would anyone want to go back during the profile creation? Nevertheless, we should open an issue and create another PR.

ntissieres commented 4 months ago

Okay, it's fine for me 👍

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud