ntissieres
commented
6 months ago There are a lot of comments about the UI, which is a bit disappointing because I specifically made a mockup last Friday to avoid that. I asked for it to be reviewed, but got no response, so I started the implementation on Sunday. Anyway:
- The problem isn't with this PR, but it's a good point you make, I'll have to adapt it in ListDrawer.
- Once again, the problem doesn't come from this PR
- That's right, I thought the association names were all small enough to fit in the box. I'm going to change that and let the width of the box adapt.
- I thought about doing a special design to make it clear that it's clickable but with the amount of stuff I had to code, I just don't have the time to do it. But I can put the text in a button so that people understand even if it's ugly
- Similarly, a better design would make it easier to understand. For now, I can add a title.
About the page for filtering events by association, it's not possible to do that in the HomeScreen. This section of the application is there to highlight associations and their events, which is why I think it's still necessary. About follow/unfollow on the list, this has already been discussed with Jonas here : #251. I'm sorry for the slightly bitter response, but a lot of these comments could have been avoided if someone had told me before I spent 24 hours coding everything to do with associations. But that's OK, thanks anyway for your comments, which are still relevant.
unglazedstamp
sonarcloud[bot]
The first thing a user sees is the active events of each association she/he follows. Reuse the ListDrawer. On top of this page, we have two buttons (or better MD component) : one with "Followed Associations" which leads to a list of followed associations by a user and one with "My Associations" which leads to a list of associations to which the user belongs. At the bottom right, there is a search button (like the one in HomeScreen) which allows the user to search an association.