search

echo75 / my-movie-db

MIT License
1 stars 0 forks source link

#CleanCode No hardcoded URLs in files #19

Closed Dr4gon closed 1 year ago

Dr4gon commented 1 year ago

@echo75 In your ReviewModal.vue I found this:

 async handleReview() {
      console.log('review submitted')
      await axios.post('http://localhost:3000/reviews', {
        imdbID: this.movieInfo.imdbID,
        text: this.text,
        rating: this.rating
      })
    }

I would move this to .env since it's environment dependant.

ghost commented 1 year ago

hardcoded URL changed to .env based URL