fix: Removes generated id from factory in favor of DB

echobind / bisonapp

A Full Stack Jamstack in-a-box brought to you by Echobind

MIT License

591 stars 28 forks source link

fix: Removes generated id from factory in favor of DB #178

Closed mthomps4 closed 3 years ago

mthomps4 commented 3 years ago

Changes

fix: Removes generated id from factory in favor of DB

Checklist

[x] Generating a new app works

Fixes #144

kgajera commented 3 years ago

Should we also remove it from our UserFactory?

I think it will also cleanup this line and allow us to remove the eslint disable: https://github.com/echobind/bisonapp/blob/canary/packages/create-bison-app/template/tests/requests/user/signup.test.ts#L94

mthomps4 commented 3 years ago

Should we also remove it from our UserFactory?

I think it will also cleanup this line and allow us to remove the eslint disable: https://github.com/echobind/bisonapp/blob/canary/packages/create-bison-app/template/tests/requests/user/signup.test.ts#L94

Yup, I'll make a note to clean that up. Forgot about the pre-existing pieces. 👍🏼

mthomps4 commented 3 years ago

@kgajera Thanks for double-checking that! I removed roles previously from unused linting - and that was needing to be stripped for the test. 👍🏼

Also, didn't realize UserFactory was still using the old custom Attrs instead of built types -- corrected that as well.

Partial<Prisma.UserCreateInput>

4fd8459