Heroku Revamp: - Githubissues

echobind / bisonapp

A Full Stack Jamstack in-a-box brought to you by Echobind

MIT License

591 stars 28 forks source link

Heroku Revamp: #181

Closed mthomps4 closed 3 years ago

mthomps4 commented 3 years ago

Changes

Heroku Revamp:

Removes heroku specific questions from prompt
Removes heroku CLI specifics from main
Adds Procfile to copied heroku files
updates post-install text to point to heroku readme links
updated conditional in readme for Deploy (future placeholder for Render, Vercel, Other)

Screenshots

Checklist

[ ] Requires dependency update?
[x] Generating a new app works

Fixes #179 Fixes #125

mthomps4 commented 3 years ago

@kgajera I was wondering about the order of these questions as well. It feels like we would want to ask the "Hosting" question before this one. And then nudge them on this after.

cc @cball

cball commented 3 years ago

If we are moving away from using the Heroku CLI than the branching for git+heroku is not required. I'd opt to remove all of it and just automatically commit for the user. they can handle setting up the remotes

mthomps4 commented 3 years ago

One more note.

If they are setting up their own remotes, do we still want this to make an empty commit? If not we can go as far as to get rid of nodegit here and potentially support Node16 in the next pass.

mthomps4 commented 3 years ago

we do want to make the initial commit, just not add the origin
but there is a javascript only git package we can migrate to and remove the nodegit dependency

Removed "origin" logic and left the package swap for another new ticket.