echobind / bisonapp

A Full Stack Jamstack in-a-box brought to you by Echobind
MIT License
591 stars 28 forks source link

feat(enhancement): generate placeholder graphql specs to match bolierplate #186

Closed mthomps4 closed 3 years ago

mthomps4 commented 3 years ago

Description of PR that completes issue here...

Changes

Note: These tests require a Factory to be generated... open for discussion, but rather than generate it here, its becomes a Typescript compile nudge.

The tests I feel are still a valid form of generation. Similar to the Nexus boilerplate, the quick not authed, find as admin, and filter list examples have been rinse/repeat on other projects so far. We are also pushing "best practice" examples out as a reminder to 1. Have A test 2. Valid request cases we would expect. In these examples, the tests also have a failed assertion with an "Updated Generated Test" reminder.

*For larger projects, the tests can also be skipped/removed if a developer is working only on a single piece of CRUD given the ticket. The counterargument being with generators the bare bones CRUD examples become manageable in a single pass.

Screenshots

generatedSpecs

Checklist

mthomps4 commented 3 years ago

@kgajera for sure -- This is def open for discussion It has helped us gain momentum pre-flight, so I wanted to throw it out here for debate.

The issue with the other is that it doesn't really infer what type of request I'm looking to make.

With this, I at least have example specs around the like example code... but totally understand both sides here.

mthomps4 commented 3 years ago

Update: Based on discussions, will be moving these to a Test Example File instead of auto generating. Leaving open as a reminder to self.

mthomps4 commented 3 years ago

Closed for #202 Documentation