search

echobind / bisonapp

A Full Stack Jamstack in-a-box brought to you by Echobind
MIT License
590 stars 28 forks source link

fix: refactor scripts import in the create-bison-app script into utils file #189

Closed kgajera closed 3 years ago

kgajera commented 3 years ago

Changes

The scripts/* files shouldn't be imported into other modules so this refactors getting and saving dev app variables into a utility file.

Fixes this error occurring when creating a new app:

Screen Shot 2021-07-15 at 5 08 01 PM

Checklist

kgajera commented 3 years ago

Nit: It would be nice if the pr template had a section on how to test the changes.

Agree with your suggestion.

You can test this by:

  1. Run npm link in the packages/create-bison-app directory
  2. Then you can create a new bison app, npx create-bison-app MyApp, and it will use your local project