search

echobind / bisonapp

A Full Stack Jamstack in-a-box brought to you by Echobind
MIT License
590 stars 28 forks source link

chore: upgrade cypress #199

Closed Patil2099 closed 3 years ago

Patil2099 commented 3 years ago

Fixes #191

kgajera commented 3 years ago

@Patil2099 The CI tests are failing after this change. Could you please look into it: https://github.com/echobind/bisonapp/pull/199/checks?check_run_id=3205525452#step:14:67

We've found the cause for this.

This line: https://github.com/echobind/bisonapp/blob/canary/packages/create-bison-app/template/tests/e2e/tsconfig.json#L2

Should be changed to: "extends": "../../cypress/tsconfig.json",

And also update the testing library dependency: https://github.com/echobind/bisonapp/blob/canary/packages/create-bison-app/template/package.json.ejs#L80

code-jenn-or commented 3 years ago

Closing Pull request, no response for 20 days. New PR opened to address the upgrade