feat: add persistent app layouts to template - Githubissues

echobind / bisonapp

A Full Stack Jamstack in-a-box brought to you by Echobind

MIT License

590 stars 29 forks source link

feat: add persistent app layouts to template #245

Closed mcavaliere closed 1 year ago

mcavaliere commented 2 years ago

Fix #242

Changes

Sets _app.tsx up to render a getLayout function for any page (or component) if it exists. This allows faster navigation between pages, since layouts that are the same between pages will not be re-rendered (since their element subtrees are the same).

References:

Also includes:

References shared footer component in logged in / logged out layouts
Makes nav links consistently use next/link around the Chakra Link component
Adds 3 placeholder pages for the default nav links

Screenshots

(prefer animated gif)

Checklist

[ ] Requires dependency update?
[ ] Generating a new app works

Fixes #xxx

mthomps4 commented 2 years ago

We should revisit this PR with the new Layout features dropping

mthomps4 commented 1 year ago

Almost a year old -- closing

mcavaliere commented 1 year ago

😢

mthomps4 commented 1 year ago

😢

Can re-open with new Next stuff