echobind / bisonapp

A Full Stack Jamstack in-a-box brought to you by Echobind
MIT License
590 stars 29 forks source link

chore: Upgrade node to 16.17.0. #274

Closed cullylarson closed 2 years ago

cullylarson commented 2 years ago

Immediately this solves an error being thrown when running yarn build:types on a new project:

[INFO] 14:51:29 ts-node-dev ver. 2.0.0 (using ts-node ver. 10.9.1, typescript ver. 4.7.4)
$ graphql-codegen --config codegen.yml
MyApp/node_modules/@whatwg-node/fetch/dist/create-node-ponyfill.js:163
      class Request extends OriginalRequest {
                            ^

TypeError: Class extends value undefined is not a constructor or null
    at createNodePonyfill (MyApp/node_modules/@whatwg-node/fetch/dist/create-node-ponyfill.js:163:29)
    at Object.<anonymous> (MyApp/node_modules/@whatwg-node/fetch/dist/node-ponyfill.js:3:19)
    at Module._compile (node:internal/modules/cjs/loader:1095:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1124:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:816:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:93:18)
    at Object.<anonymous> (MyApp/node_modules/@graphql-tools/url-loader/cjs/defaultAsyncFetch.js:4:17)
    at Module._compile (node:internal/modules/cjs/loader:1095:14)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command

However, it's also probably just a good idea to use a newer version of node.

Checklist