search

echocat / gradle-golang-plugin

Gradle plugin to build, test and do other stuff of Golang projects.
https://github.com/echocat/gradle-golang-plugin
Mozilla Public License 2.0
44 stars 8 forks source link

Gradle 3.0+ compatibility: renamed Build and Test tasks #16

Closed billsegall closed 7 years ago

billsegall commented 7 years ago

Gradle 3.0+ compatibility: renamed Build and Test tasks to fix the standard lifecycle plugins task naming conflict.

blaubaer commented 7 years ago

Hey @billsegall thanks a lot for your contribution. Sorry for my late response I will hurry up in the future. 😄

Could you please recheck your contribution? It seems to me that you renamed at too many places build and test with buildGolang and testGolang. Especially you call for example in BuildTask.java the golang binary with also with buildGolang instead of build. I assume that the go binary is not able to handle a command like buildGolang. 😉

Could you please verify this? Did you build it locally by your own and test it with a sample project before submitting it?

Sorry for do not have suitable enough testing for this right now. I'am on it - before this is achieved manual testing is required. 😞

Cheers, Gregor

billsegall commented 7 years ago

Gregor,

It wasn't clear to me how to run a local copy in my project. I ran test and check targets but that was clearly insufficient. I'm a long way from having any gradle expertise so perhaps we should kill this PR and instead treat is as an issue with gradle-3.0+ compatibility evidenced by the lifecycle plugin.

Bill.