echofox-team / echofon-firefox-unofficial

Echofon Unofficial - maintained version of Echofon: full featured, super clean Twitter app for Firefox.
http://echofox-team.github.io/echofon-firefox-unofficial/
70 stars 10 forks source link

Http/Https #31

Closed Mostafa20xx closed 8 years ago

Mostafa20xx commented 9 years ago

When I click to open a twitter photo from echofon it opens in http first then redirect to https protocol

When open a twitter account it goes to ''https://twitter.com/#!/realmadridarab'' then redirect to ''https://twitter.com/realmadridarab''

please fix it in next releases to open all twitter links in https

In firefox 40/Windows 10 : the windows of echofon doesn't have close button

capture

thanks for keeping this addon alive :D

gizmecano commented 9 years ago

The two links you provided seem to use both https protocol. On the other hand, I have found one occurrence of the /#!/ string and suggest a pull (cf. #32) in order to remove it, but I'm not sure it will be sufficient to solve this issue.

Mostafa20xx commented 9 years ago

no the http thing when i open a photo link like this ''http://twitter.com/FilGoalLive/status/636949676252622849/photo/1''

it redirects to https://twitter.com/FilGoalLive/status/636949676252622849/photo/1

I ask to make it open all twitter links in https without redirecting!

ath0mas commented 8 years ago

Close cross and user link have been fixed few days/weeks ago. @Mostafa20xx Can you check for images links with #39 future release (zip file to rename as xpi) please? I don't see any redirect from http to https for images today

Mostafa20xx commented 8 years ago

Yeah Now it works with users, Thank you

but it still for images it opens with http then redirects to https

Mostafa20xx commented 8 years ago

capture this from browser history and when I hover over an image link in echofon its show http:...........

YoruNoHikage commented 8 years ago

I don't think we can do much here, it's from Twitter API, see here https://dev.twitter.com/overview/api/entities-in-twitter-objects#media

expanded_url seems to be always http while there is a media_url and media_url_https but that leads to the file, not the Twitter page.

However, profile pictures are loaded with http, but I think we could change this (there is a https property for them profile_image_url_https).

Mostafa20xx commented 8 years ago

first Thanks for your efforts :+1: OK no problem actually i never tried to open profile pic through echofon I just tried it and it opens the user profile in https directly

YoruNoHikage commented 8 years ago

I was monitoring requests, that's why ;) So, closing this as it can't be solved.