search

echofox-team / echofon-firefox-unofficial

Echofon Unofficial - maintained version of Echofon: full featured, super clean Twitter app for Firefox.
http://echofox-team.github.io/echofon-firefox-unofficial/
69 stars 10 forks source link

[WIP] Replace toggleSidebar() with new SidebarUI methods #38

Open YoruNoHikage opened 8 years ago

YoruNoHikage commented 8 years ago

While fixing blank tweets problem, I encountered warnings about this methods being deprecated. Is there anybody still using old versions of Firefox ?

YoruNoHikage commented 8 years ago

Well... I just encountered new errors, do not merge now please. :'(

ath0mas commented 8 years ago

Just to paste browser console deprecation warning you mentioned:

DEPRECATION WARNING: toggleSidebar() is deprecated, please use SidebarUI.toggle() or SidebarUI.show() instead
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/Add-ons/Code_snippets/Sidebar
...
ath0mas commented 8 years ago

Where to find documentation on SidebarUI?

YoruNoHikage commented 8 years ago

I think this is this object https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/ui_sidebar#Sidebar%28options%29

YoruNoHikage commented 7 years ago

Could be useful : https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sidebar.js#328-337