Closed YoruNoHikage closed 8 years ago
I pushed similar commit to my fork at the same time ^^
We should add commits to this branch and when ready to merge, squash them all into a single one
:+1:
echofox@echofox-team
or echofox@echofox.github.com
for <em:id>
?
Did you see http://echofox.github.io/ ? So, nope ! xD
Alright :laughing:
Ah seems better than the other, just signed a new version ! Let's try it ! (don't need to be OS-specific actually)
Working fine. I just figured out how you sign it on AMO without review process :p
We changed addon uuid but was it really necessary?
If we go on with it, we should rename Echofon to Echofox everywhere in code, migrate welcome.xul and remove subscribe? but registered app for key when connecting to Twitter to add acount is "Echofon, by naan studio"... + /echofon
prefixes, synchronisation system, etc.
Same UUID causes validation fail, so we have to change it. For the rest, well, it's just about copyright and stuff we wanted to change before...
Ok, so I would suggest not "altering" more original addon: keep Echofon identity everywhere, and set Echofox/Echofox Team only as maintainers
I agree but don't you think it would be better to have "Echofon Unofficial" as the name ? Since UUID is different, installing the new version will not replace the old one !
Ping @echofox-team/core for name again ^^ see @YoruNoHikage question ahead
Original name was "Echofon for Firefox" ; so I suggest "Echofon for Firefox - unofficial"
A bit long... Just saying :-°
Well, time has flown and Firefox 44 is here, breaking stuff fixed with #36, so we have to make a release, preferably signed. So, we should go for Echofon Unofficial (simpler is better !) and echofon-unofficial@echofox-team
as ID.
Can you change this, maybe squash commits and merge ? Do you have time to do this ?
I should have time to do it later today
Squashed commits and merged. Are we ready to tag version 2.6, sign XPI and create a release on GitHub with all that?
... I may have made a mistake, trying signing from AMO pages I started "submit a new addon", checked "do not list on this website" (step 2), and stopped at step 3 but now, it is listed in "My addons" page, and "delete" button tells me:
Deleting your add-on will permanently remove it from the site and prevent its GUID from being submitted again, even by you.
(not yet deleted)
I may have blacklisted GUID echofon-unofficial@echofox-team ? :disappointed:
Will we be able to sign addon with each of our personal accounts? or should we create a shared account on AMO for @echofox-team/core?
We should test and sign before releasing/tagging it on GitHub. I'm on it !
EDIT : oh damn... We should totally create a shared account.
@YoruNoHikage Chat on gitter?
:+1:
As I was saying on #3, we have to change some info for publishing.
First, ID, I change it to
echofox@echofox-team
since we do not have any domain/mail. Second, the name, well it's Echofox, no problem here. Third, version : 2.6 seems right to me since it's not a major release but not just a fix.What about the rest ? Any thoughts ?