echofox-team / echofon-firefox-unofficial

Echofon Unofficial - maintained version of Echofon: full featured, super clean Twitter app for Firefox.
http://echofox-team.github.io/echofon-firefox-unofficial/
69 stars 10 forks source link

Add line breaks to overlong lines #56

Closed daemionfox closed 7 years ago

daemionfox commented 8 years ago

Currently any tweets that are longer than the width of the view window cause the text of every other tweet in the timeline to float to the right.

Suggestion is to force a breaking space into over-long lines (longer than the view window) in order to ensure every other tweet remains readable.

Ma-ve commented 8 years ago

What type are you using? Window, sidebar, or panel?

I've come across this issue repeatedly, but only made the connection to strings that are too long this past week. I'm really interested in sorting this out, and I would love to create a pull request, but I have one question: is it possible to inspect the Echofon panel?

YoruNoHikage commented 8 years ago

Yes tough issue... @Ma-ve you can activate the browser toolbox that can help you inspecting Echofon https://developer.mozilla.org/en-US/docs/Tools/Browser_Toolbox

daemionfox commented 8 years ago

Fedora Linux 21, running Firefox 46 Echofon Unofficial 2.6.1 Application Mode: Panel

Ma-ve commented 8 years ago

I've had a quick gander, and two possible solutions so far:

On .echofon-status-message:

Thoughts @YoruNoHikage?

YoruNoHikage commented 8 years ago

max-width might be the way to go but since the panel is variable, we have to work with it... The other solution is not really aesthetic. :cry:

Ma-ve commented 8 years ago

max-width has no effect on the layout, and does nothing, even when set to 10px. I'm not sure why, but it could be a reasonable solution. I have no idea how it affects older/newer versions other than stable.

YoruNoHikage commented 8 years ago

Wow, that's weird. I'll try something when I get some time. If you think this solution is the best, you can open a pull request, I'll test it. :+1:

ath0mas commented 7 years ago

Anyone to check PR #60 I just pushed please?