Upcoming api changes

[YoruNoHikage]

Recently, Twitter changed its API to match new criterias for the tweets making Echofon displaying truncated tweets (see #65). This PR is an attempt to fix that. If you could test it reporting every trouble you might encounter, it will be great, I'm not confident about the changes I made. '^^

EDIT: if you want, here's a unsigned build you can use: echofon_unofficial-2.6.3.xpi.zip

[YoruNoHikage]

Anyone ? @echofox-team/core

[MickBim]

I'll try during the holidays (not before new year's eve sorry)

On Thu, Dec 22, 2016 at 9:01 PM, Alexis Launay notifications@github.com wrote:

Anyone ? @echofox-team/core https://github.com/orgs/echofox-team/teams/core

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/echofox-team/echofon-firefox-unofficial/pull/70#issuecomment-268878801, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_bUPbycZITBHOxWEuCEHb04Jfzh0sVks5rKtcAgaJpZM4LMUWi .

[YoruNoHikage]

Thanks, don't worry, no rush! :D

[MickBim]

By the way, do you have screenshots of the changes your modifications in code made ?

On Thu, Dec 22, 2016 at 9:43 PM, Alexis Launay notifications@github.com wrote:

Thanks, don't worry, no rush! :D

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/echofox-team/echofon-firefox-unofficial/pull/70#issuecomment-268886578, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_bUKajh3XpTln5RsbkiVe3IE-7RPSpks5rKuEJgaJpZM4LMUWi .

[YoruNoHikage]

No problem, here it is!

Left: before. Right: after.

[MickBim]

Great ! :)

Do you have also planned the embedded tweets ?

On Fri, Dec 23, 2016 at 1:16 AM, Alexis Launay notifications@github.com wrote:

No problem, here it is! [image: image] https://cloud.githubusercontent.com/assets/969003/21444405/52e7a576-c8ad-11e6-8260-1687146e489c.png

Left: before. Right: after.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/echofox-team/echofon-firefox-unofficial/pull/70#issuecomment-268919103, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_bUKiXTO8oSht0I-phcNvMBd1QdiIuks5rKxLhgaJpZM4LMUWi .

[YoruNoHikage]

Yes, but as it requires new development, I think I'll do after some rewrite in #71.

[YoruNoHikage]

Any news?

[MickBim]

Sorry, didn't have time to check on it :/

On Sun, Jan 15, 2017 at 3:37 PM, Alexis Launay notifications@github.com wrote:

Any news?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/echofox-team/echofon-firefox-unofficial/pull/70#issuecomment-272699061, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_bUDzTz34D9gz1w2-xmPd-B0-0PHw7ks5rSi8SgaJpZM4LMUWi .

[YoruNoHikage]

After using it, I don't see much trouble. I'm gonna merge and release this. If anyone finds a bug, please open an issue.

[MickBim]

Hello

Just tried it Had messed up display, but after clearing cache in the Echofon options, everything went back to normal

Thank you !

Next step, embedded tweets :D

On Sat, Feb 11, 2017 at 3:39 PM, Alexis Launay notifications@github.com wrote:

Merged #70 https://github.com/echofox-team/echofon-firefox-unofficial/pull/70.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/echofox-team/echofon-firefox-unofficial/pull/70#event-958351340, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_bUC51dvroLuhgUcHVj5_tI5kQcR6Iks5rbcgfgaJpZM4LMUWi .

[MickBim]

Well, I take back what I said yesterday, I encountered some serious bugs after I launched Firefox again

Here is the normal view after clearing the cache : And here is the bugged view after I close Firefox and restart it again :

As you can see, the order of the tweets is still there, but most of the tweets aren't (couldn't find the "logic" in it)

But if I wait for new tweets to arrive, they are displayed without anybugs

I first I thought it was my personal fork that was buggy but I tried using the master here and same problem

I also tried on a new blank FF profile with only Echofon installed as plug-in, same problem

Am I the only one with this behaviour ?

[YoruNoHikage]

Well, there was some trouble with the cache SQLite database but it revealed to me another bug that I didn't see before. I think it's related to the user id not being well-saved in the database. I'll push the fix for the first bug and then look into the next one before the release.

[MickBim]

Well, your latest modifications with the "new" SQLite databasefixed the bugged view with empty tweets but a new bug appears in the DM section. The panel view show the content of the DMs but when you click on them they're empty...

[MickBim]

But thank you for your work :)

I'll try to see how github work to share my modifications to show the tweets with carriage return Well, they're not all my modifications (I found some on a japanese or chinese website) but I can't remember which one were mines...

[YoruNoHikage]

Oh damn... I feared that DMs were sharing the same database table... :(

EDIT: Or maybe it's my reverted changes's fault! I'll test tomorrow :D

[YoruNoHikage]

Alright, DM fixed!

[MickBim]

Works great, thanks !