search

echofox-team / echofon-firefox-unofficial

Echofon Unofficial - maintained version of Echofon: full featured, super clean Twitter app for Firefox.
http://echofox-team.github.io/echofon-firefox-unofficial/
69 stars 10 forks source link

Fix CSS #73

Closed MickBim closed 7 years ago

MickBim commented 7 years ago

Fix the new line break for long words

YoruNoHikage commented 7 years ago

Interesting... The CSS used to be like this before https://github.com/echofox-team/echofon-firefox-unofficial/commit/204fe8ad8975dc37fd7459661da9447cd96477ee

I'll try different things to see what's work but if it works for you, that's already great. ;)

MickBim commented 7 years ago

I still have the previous version of window.js of your link So maybe my modifications won't work with the new version which is in the master (yeah, my forked version is kinda weird :p)

YoruNoHikage commented 7 years ago

Don't worry, I got this! I had a weird fork myself too before we all put effort in this repo ;)

MickBim commented 7 years ago

Do you see my other pull request for multi-lines tweets ? Can't seem to find it :/

YoruNoHikage commented 7 years ago

The branch is on your repo, but there is no PR created.

EDIT: You actually did a PR on your own repo https://github.com/MickBim/echofon-firefox-unofficial/pull/1 and you merged it in your master (that's why I couldn't see it in the first place).

MickBim commented 7 years ago

I guess now it should be visible (but the CSS fix is also in it, this thing is a mess :|)

On Mon, Feb 20, 2017 at 12:22 AM, Alexis Launay notifications@github.com wrote:

The branch is on your repo, but there is no PR created.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/echofox-team/echofon-firefox-unofficial/pull/73#issuecomment-280958643, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_bUHovBa_25fPeL5zmPK3Rnjx7WRk9ks5reM6_gaJpZM4MFnSl .

YoruNoHikage commented 7 years ago

You can authorize me to edit the PR and I'll clean it ;) https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

MickBim commented 7 years ago

It's already checked (for my 2 pull requests)

YoruNoHikage commented 7 years ago

It's clean now :)

YoruNoHikage commented 7 years ago

Hum... Fail? image

MickBim commented 7 years ago

tw_github Works here... Strange Maybe the changes in window.js (my file is intact and doesn't have the modifications in the link you pasted up this thread)

And If I had known, we could have spoken French all this time :D

YoruNoHikage commented 7 years ago

When refactoring everything in next branch, I finally found why we had so much trouble with line breaks. I'll close this PR as it is not required anymore.