search

echofox-team / echofon-firefox-unofficial

Echofon Unofficial - maintained version of Echofon: full featured, super clean Twitter app for Firefox.
http://echofox-team.github.io/echofon-firefox-unofficial/
70 stars 10 forks source link

Fix close button visibility in panel #9

Closed nikou closed 9 years ago

YoruNoHikage commented 9 years ago

My close button is here but that's not the really great :/ On Mac screenshot 2015-03-09 a 17 11 38

EDIT : On Linux, there's nothing to do, it's working already. Weird.

devon314 commented 9 years ago

when i hover my mouse over the top right this little shape shows up and clicking it closes the panel close

ath0mas commented 9 years ago

Fix works fine for me, on Windows

For now, i had no default style and "empty" hover style: actual

and with fix, default: normal hover: hover

@YoruNoHikage can you check this pull request applied to Firefox on Linux? Any change in close button display or position?

And if someone can chek on Mac please

ath0mas commented 9 years ago

What's strange is that few months/years ago, titlebar was always visible and close button was shown in it Since then, titlebar disappears quite immediately on open

YoruNoHikage commented 9 years ago

The screenshot above was taken on Mac OS. On Linux, there was no problem, I'll try with the fix to see if it's not breaking anything.

YoruNoHikage commented 9 years ago

As I said before, on Linux, there was nothing to do. But when you apply this fix, it's getting weird. See : no hover Hover : hover

Edit : after investigation, it has something to do with the skins. .tabs-closebutton is a class given by the browser. So what do we do ?

ath0mas commented 9 years ago

Is the red border drawn by Firefox or did you added it yourself?

Change is supposed to set same style as browser tabs "close" cross, with same default and hover

YoruNoHikage commented 9 years ago

This red border comes from this line : https://github.com/AntoineTurmel/echofon-firefox-unofficial/blob/master/chrome/Echofon/skin/linux/echofon.css#L15

Hum, I don't think so. This cross is from the browser itself. I checked on Mac and it doesn't exist... I think we should first get rid of this ugly red border line (surely a debug).

ath0mas commented 9 years ago

Ok fine Was "ready to merge" for me on Windows Is this fix OK for you on Linux and Mac now?

YoruNoHikage commented 9 years ago

Ready to merge :)