search

echonest / remix

Echo Nest Remix: The Internet Synthesizer
http://echonest.github.com/remix
414 stars 90 forks source link

Numpy19 #32

Closed nicolamontecchio closed 10 years ago

nicolamontecchio commented 10 years ago

I made a few changes so that remix should be numpy-1.9 compatible. I'm using the latest numpy from git, where they removed libnumarray. I've been using examples/swinger as check, it seems to work, though I can't say I have tested it extensively.

tkell commented 10 years ago

Thanks for doing this! Is this going to break people using numpy 1.8?

nicolamontecchio commented 10 years ago

No, it should work. I tried it in a couple of virtual environments with numpy 1.6 and 1.8, all good.

tkell commented 10 years ago

Rad rad rad! Thank you again.

nicolamontecchio commented 10 years ago

no problem, hope it works :)

MikeiLL commented 10 years ago

Excuse my ignorance, but when i run easy_install or pip install -U numpy I get a message the 1.8.1 is the most up to date release - on my osX and CentOS servers.

Would one have to install numpy 1.9 in some other way, and may it make just as much sense to wait?

Thanks a ton.

Mike

On Jun 10, 2014, at 9:42 AM, Nicola Montecchio wrote:

I made a few changes so that remix should be numpy-1.9 compatible. I'm using the latest numpy from git, where they removed libnumarray. I've been using examples/swinger as check, it seems to work, though I can't say I have tested it extensively.

You can merge this Pull Request by running

git pull https://github.com/nicolamontecchio/remix numpy19 Or view, comment on, or merge it at:

https://github.com/echonest/remix/pull/32

Commit Summary

taking out references to libnumarray, which is not anymore in numpy 1.9 fixed dirac! fixed the other two modules; re-fixed number of channels from last commits File Changes

M external/cAction/actionmodule.cpp (96) M external/pydirac225/diracmodule.cpp (128) M external/pydirac225/setup.py (9) M external/pysoundtouch14/soundtouchmodule.cpp (96) M setup.py (13) Patch Links:

https://github.com/echonest/remix/pull/32.patch https://github.com/echonest/remix/pull/32.diff — Reply to this email directly or view it on GitHub.

nicolamontecchio commented 10 years ago

We are trying to avoid having remix break when the new numpy version comes out

MikeiLL commented 10 years ago

What, please, is a good way to update local copy? Pull or merge into site-packages/echonest/remix/?