This PR is reorganized changes of #28,
but without any code formatting or optimization.
It's just for fixing compatibility of 1.13.2.
Details are all in the commit messages.
If it's not clear enough, I think the description in #28 would be helpful too.
BTW,
when I worked on it, I notice that there is some problem of code style.
Most of the indent is TAB, but sometimes they are SPACE or even mixed of TAB and SPACE.
Indent is not consistency somewhere.
The ordering of import is not consistency somewhere.
There are many trailing whitespace (include TAB and SPACE) in the code.
A suggestion for preventing the situation above is defining code style in the project.
You can try to use IDE which supports EditorConfig (e.g. IntelliJ IDEA) for basic code style setting.
Actually, I have used .editorconfig and project setting of IntelliJ IDEA for defining code style exactly in this PR. (TAB indent & Trim trailing whitespace)
Everything is ready but only wait for someone using IDEA to reformat all the code.
(It will make a huge change, so I didn't do it in this PR)
I think it would be helpful for multiuser cooperation, please consider about it.
echurchill
commented
5 years ago
This PR is reorganized changes of #28, but without any code formatting or optimization. It's just for fixing compatibility of 1.13.2.
Details are all in the commit messages. If it's not clear enough, I think the description in #28 would be helpful too.
BTW, when I worked on it, I notice that there is some problem of code style.
A suggestion for preventing the situation above is defining code style in the project. You can try to use IDE which supports EditorConfig (e.g. IntelliJ IDEA) for basic code style setting. Actually, I have used
.editorconfigand project setting of IntelliJ IDEA for defining code style exactly in this PR. (TAB indent & Trim trailing whitespace) Everything is ready but only wait for someone using IDEA to reformat all the code. (It will make a huge change, so I didn't do it in this PR) I think it would be helpful for multiuser cooperation, please consider about it.