Replacing period to comma.

[filipe-cauduro]

When I try to script, happens to replace the period from a decimal column to a comma, making the select list have more columns than the insert into statement.

I'm using the v0.1.3.

I don't know how can I get you more information, if you'd like something just let me know.

[ecirpnaes]

If you can supply me with the table schema and some sample data, that would be great.

[YomaSun]

I have the same problem here on a 'german' database. Maybe ADS get it from windows country selection -> germany. (The App ADS itself runs in english)

` float: 1.23 in english is float: 1,23 in german so we got more columns i think we need convert floating points

this works: create table [#temptblB] ( [number1] [decimal] (18,2) NULL ); insert [#temptblB] ([number1]) select 422.74

this works not: insert [#temptblB] ([number1]) select 422,74 `

Or if u can set InvariantCulture?

[ecirpnaes]

Yup. I believe this is an issue with the database collation. I'll have to look into checking that and doing a covert on it before the insert.

On Mon, Mar 30, 2020 at 2:35 AM YomaSun notifications@github.com wrote:

I have the same problem here on a german database, u cant see it in sql schema. MS sql server management studio has the same problem btw.

` float: 1.23 in english is float: 1,23 in german so we got more columns we need convert

this works: create table [#temptblB] ( [number1] [decimal] (18,2) NULL ); insert [#temptblB] ([number1]) select 422.74

this works not: insert [#temptblB] ([number1]) select 422,74 `

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ecirpnaes/SimpleDataScripter/issues/3#issuecomment-605810247, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWH4WYTR4XBH4MG66HHVZ3RKA4SRANCNFSM4KWRVKAA .

[YomaSun]

My values are: select SERVERPROPERTY('collation') --> Latin1_General_CI_AS windows country property: german

[ecirpnaes]

I've pushed a fix that should work for you. It's not released yet, but feel free to grab it and let me know if it works for you. And thanks for reporting the issue. Nice to know people are using the extension. (MS does not release stats for Azure Extensions).

Here's the release. https://github.com/ecirpnaes/SimpleDataScripter/releases/tag/0.1.4

On Wed, Apr 1, 2020 at 2:28 AM YomaSun notifications@github.com wrote:

My values are: select SERVERPROPERTY('collation') --> Latin1_General_CI_AS windows country property: german

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ecirpnaes/SimpleDataScripter/issues/3#issuecomment-607060984, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWH4W4CXIOPXOBJSKW2Y4TRKLNIZANCNFSM4KWRVKAA .

[YomaSun]

great thanks, it worked good

for interesting: why you use the insert/select syntax, it is faster than the default insert?

[ecirpnaes]

Whether it's faster or not depends on many factors, such as number of rows, type of data, and how you have your database set up for transaction logging. That said, I use the insert/select syntax mainly to keep the file size down, because using the "insert into values (...) syntax effectively double the amount of text scripted out. If you have a lot of rows it's very easy to run out of memory trying to load the script.

My aim with the extension was to build something simple and lightweight and easy to use. I could have built something with lots of options, like choosing how to script, saving data to file system, etc.. but this was not really the aim of the extension.

On Tue, Apr 21, 2020 at 4:57 AM YomaSun notifications@github.com wrote:

great thanks, it worked good

for interesting: why you use the insert/select syntax, it is faster than the default insert?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ecirpnaes/SimpleDataScripter/issues/3#issuecomment-617049011, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWH4W44TPJ3SWVKGZW4DRTRNVNWFANCNFSM4KWRVKAA .

[YomaSun]

Ah ok thanks. Yes shorter is better.