search

eckara / CSSS

2 stars 1 forks source link

Indv solar disagg #11

Closed bmeyers closed 6 years ago

bmeyers commented 6 years ago

My understanding from @mtabone is that this is the most current version of the code base and should be what new users work with.

bmeyers commented 6 years ago

@eckara @mtabone please review and accept merge or provide feedback on necessary changes. If you decide to accept the merge, please delete other branches, so we can clone into the public GISMo Team repo. Once we've moved the repo, we can invite you if there's more work that you need to do.

mtabone commented 6 years ago

Hey Bennet.

May I do this on Saturday?

On Thu, Jul 19, 2018 at 4:08 PM Bennet Meyers notifications@github.com wrote:

@eckara https://github.com/eckara @mtabone https://github.com/mtabone please review and accept merge or provide feedback on necessary changes. If you decide to accept the merge, please delete other branches, so we can clone into the public GISMo Team repo. Once we've moved the repo, we can invite you if there's more work that you need to do.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eckara/CSSS/pull/11#issuecomment-406440944, or mute the thread https://github.com/notifications/unsubscribe-auth/AEZHTZ5IxbUfvpl6UUew0RBUSHlEb2Mwks5uIRFkgaJpZM4VXNJV .

bmeyers commented 6 years ago

@mtabone absolutely

eckara commented 6 years ago

If MT approves so! ;)

On Sun, Jul 22, 2018, at 5:36 PM, Michaelangelo Tabone wrote:

Merged #11[1].

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub[2], or mute the thread[3].

Links:

  1. https://github.com/eckara/CSSS/pull/11
  2. https://github.com/eckara/CSSS/pull/11#event-1746642256
  3. https://github.com/notifications/unsubscribe-auth/AGmevUli_KKuh8kM7bPVfcmzaIT3DWJfks5uJRqHgaJpZM4VXNJV
mtabone commented 6 years ago

Full disclosure, I didn't test any of the cross functionality. (I.e. ADMM and SOlarDisagg). But I believe that the two should work separately in the same package just fine.

On Sun, Jul 22, 2018 at 9:00 PM, Emre Kara notifications@github.com wrote:

If MT approves so! ;)

On Sun, Jul 22, 2018, at 5:36 PM, Michaelangelo Tabone wrote:

Merged #11[1].

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub[2], or mute the thread[3].

Links:

  1. https://github.com/eckara/CSSS/pull/11
  2. https://github.com/eckara/CSSS/pull/11#event-1746642256
  3. https://github.com/notifications/unsubscribe-auth/AGmevUli_ KKuh8kM7bPVfcmzaIT3DWJfks5uJRqHgaJpZM4VXNJV

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/eckara/CSSS/pull/11#issuecomment-406932620, or mute the thread https://github.com/notifications/unsubscribe-auth/AEZHTZTswc7xizYd0TLbhZQt5rAql6dFks5uJUpbgaJpZM4VXNJV .

bmeyers commented 6 years ago

Thanks @mtabone! Can you explain more what you mean by "cross functionality"? Is there more work to be done there?

mtabone commented 6 years ago

In general, Emre and I worked on separate functionalities:

The wrapper functions in my branch do not specifically utilize the ADMM solver, and given the way that Emre implemented it initially (I'm not sure if it's still like this) they cannot.

On Mon, Jul 23, 2018 at 3:51 PM, Bennet Meyers notifications@github.com wrote:

Thanks @mtabone https://github.com/mtabone! Can you explain more what you mean by "cross functionality"? Is there more work to be done there?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eckara/CSSS/pull/11#issuecomment-407225770, or mute the thread https://github.com/notifications/unsubscribe-auth/AEZHTaNydKwnkWnOlA1tx0GQbePKPg8Pks5uJlN5gaJpZM4VXNJV .