search

ecklf / tailwindcss-figma-plugin

Figma Plugin for Tailwind CSS
https://www.figma.com/community/plugin/738806869514947558/Tailwind-CSS
MIT License
269 stars 16 forks source link

Skip the currentColor #113

Closed allymparker closed 4 years ago

allymparker commented 4 years ago

This PR skips the current: 'currentColor', section of the default Tailwind stub which currently causes the plugin to fail.

I chose to skip this class as it doesn't really make sense in Figma.

Fixes #105

ecklf commented 4 years ago

Thanks for fixing this, but I'll rework this whole import thing soon. While trying to evaluate the tailwind.config.js code sounded like a convenient idea on paper, it just adds too many possibilities of error and an unclear way to use the plugin. Apart from that, there is no way to obtain computed values. Thus I, unfortunately, will need to add an extra conversion step via tailwinds resolveConfig.

allymparker commented 4 years ago

Fair enough. I did wonder about that. If possible it'd be great to get this merged/deployed anyway just to help people fall into the "pit of success".

I'd love to get involved in supporting the project in the next phase?

ecklf commented 4 years ago

Fair enough. I did wonder about that. If possible it'd be great to get this merged/deployed anyway just to help people fall into the "pit of success".

I'd love to get involved in supporting the project in the next phase?

Got a solution in mind for this weekend, can @ you when I am pushing 👍

allymparker commented 4 years ago

Sounds great!

On Wed, 8 Jul 2020, 12:17 impulse, notifications@github.com wrote:

Fair enough. I did wonder about that. If possible it'd be great to get this merged/deployed anyway just to help people fall into the "pit of success".

I'd love to get involved in supporting the project in the next phase?

Got a solution in mind for this weekend, can @ you when I am pushing 👍

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/impulse/tailwindcss-figma-plugin/pull/113#issuecomment-655454548, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPV6SLLIKLUHZPK2YXJNPDR2RIVHANCNFSM4OP4WE4Q .

ecklf commented 4 years ago

@allymparker just pushed a new version with your fix (also with new import system)

allymparker commented 4 years ago

AFI can see the main difference in the import system is using the minified tailwind for default and using standard json parsing of the config, right?

Edit: Ahhh I see - you resolve the config into the tailwind.json using NPX. Nice

ecklf commented 4 years ago

AFI can see the main difference in the import system is using the minified tailwind for default and using standard json parsing of the config, right?

Edit: Ahhh I see - you resolve the config into the tailwind.json using NPX. Nice

Yeah I made a small helper package so people can quickly generate a json that can be parsed in good fashion.