Closed JasonDocton closed 2 years ago
vercel[bot]
commented
2 years ago This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/ecklf/tailwindcss-radix/3xLY1JxC9M9ftHws1dLS4dqpn1Dp
âś… Preview: https://tailwindcss-radix-git-fork-jasondocton-main-ecklf.vercel.app
ecklf
commented
2 years ago @JasonDocton thanks for the PR. I did notice --radix-tabs-content-transform-origin doesn't seem to exist in the radix primitives codebase. Am I missing something?
JasonDocton
commented
2 years ago Hey @ecklf! Thanks for making this repo! Super useful!
The transform origin part can be removed- just added that while testing a few things.
From what I tinkered with, adding “active” was all that was needed. For coverage, adding “inactive” could also be useful. “On” is another data state used by Toggle and ToggleGroup, but it’ll take a bit more to add that if interested since it can’t be wrapped in quotes. [data-state-“on”] won’t work, but [data-state-on] does.
ecklf
commented
2 years ago From what I tinkered with, adding “active” was all that was needed. For coverage, adding “inactive” could also be useful.
Yeah good point, will add this after merging.
“On” is another data state used by Toggle and ToggleGroup, but it’ll take a bit more to add that if interested since it can’t be wrapped in quotes. [data-state-“on”] won’t work, but [data-state-on] does.
From what I see there should be no difference to the other ones. I'll check it out and add it to the next release if it doesn't require any extra work.
Edit: Just tested and works just fine with Toggle. Feel free to try it out with the new release.
Thanks again ~
Radix-Ui's Tabs component uses a data-state-active rather than data-state-open. This pr includes the active state and will allow for styling an active tab.