search

eclab / edisyn

Synthesizer Patch Editor
Apache License 2.0
533 stars 49 forks source link

Fix chopping off 16th character from Blofeld patch name #1

Closed polluxsynth closed 7 years ago

polluxsynth commented 7 years ago

Hi Sean,

Trying to get the compile-build-run cycle to work I attempted to fix the bug causing the 16th character in the patch name to be chopped off when sending to the Blofeld.

Also added a .gitignore file to avoid all the *.class files (after compilation) showing up in git. I've just used command line based tools, so perhaps this isn't a problem when using an appropriate IDE.

/Ricard

eclab commented 7 years ago

  1. In fact I'm an old fogey -- I'm using SVN rather than git on github (!) so .gitignore doesn't do anything for me. But if it'd be useful to you I could add it.

  2. I had fixed the Blofeld patch name bug as well (or I think I did) in parallel with you. Check it out and let me know.

polluxsynth commented 7 years ago

  1. When we switched to git at work from using CVS and SVN for a long time it felt like a breath of fresh air ... like finally someone had made a version control system that was actually useful ... Anyway, I can relate to the 'old hat' philosophy too, I still use vi for editing and a Nokie 3510i as my cel phone... I think it would be handy to have a .gitignore not just for my sake but also for others who check out the repository (using git!).

  2. Your name fix looks identical to mine (or vice versa, depending on how you look at it), so keep yours.

I'll pull in your fixes to my fork and then resubmit the pull request with just the ,gitignore.