eclab / edisyn

Synthesizer Patch Editor
Apache License 2.0
533 stars 49 forks source link

Kawai K4r Patch Updates #26

Closed diemonster closed 3 years ago

diemonster commented 4 years ago

Hi --- loving this editor, thank you for your hard work!

My main issue is that with the Kawai K4r, realtime param changes are not reflected except for on the 'global' page. As such, my issue is almost identical to https://github.com/eclab/edisyn/issues/20.

I realize that the K4/K4r has an archaic MIDI implementation, and there are likely limitations for realtime changes. However, there is another editor for Ctrlr that works with the K4r that does allow for realtime changes, but it is otherwise not as well done as yours (i.e. it cannot accept program changes from the synth).

I'm curious if you would consider implementing an event handler for mouseup events or state changes from the panel(s) that sends a program dump back to the synth. This seems like a potentially more elegant solution than the 'repeated program dump' fallback which is not tied to user actions.

eclab commented 4 years ago

I don't have a K4r, but the K4 should respond properly to all of Edisyn's realtime changes: however it won't display them onscreen. Give me some specific, reproducible examples and I'll try to replicate them on my K4. Real-time changes should be working fine.

diemonster commented 4 years ago

@eclab primary example that I can consistently repro is changing any source's course tuning, level, or any envelope param.

Made a quick video for example: https://youtu.be/X18iGlIBBXA

You can see in the video, if I flip a source's "on" switch on and off again, the current state of the panel is transmitted similar to hitting cmd+u.

eclab commented 4 years ago

I found the bug. Caused by fat-fingered modifications I made to the K4 editor to fix some mute issues. And yes, mute should automatically resend the whole patch (mute can't be sent in real time). I'll have it out in the next revision. In the mean time, send me email (see my address on the front of the manual) and tell me what OS you're running I'll build a beta version for you to test.

ktivdv commented 4 years ago

I would like the beta version too! I have a k4r and have struggled with it as well. Sending email...

On Sat, 25 Jul 2020 at 03:54, Evolutionary Computation Laboratory < notifications@github.com> wrote:

I found the bug. Caused by fat-fingered modifications I made to the K4 editor to fix some mute issues. And yes, mute should automatically resend the whole patch (mute can't be sent in real time). I'll have it out in the next revision. In the mean time, send me email (see my address on the front of the manual) and tell me what OS you're running I'll build a beta version for you to test.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/eclab/edisyn/issues/26#issuecomment-663793028, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESL2BJOAIPVGCXJ4DCMTT3R5I3LVANCNFSM4PHE5JNQ .

diemonster commented 3 years ago

Just confirmed v25 has solved the issue here, closing...