search

eclab / edisyn

Synthesizer Patch Editor
Apache License 2.0
551 stars 51 forks source link

Some more dstation fixes #46

Closed cpacejo closed 2 years ago

cpacejo commented 2 years ago

Hi, a few more fixes for the D Station. Also a build fix for an unrelated synth.

eclab commented 2 years ago

The Kawai K1 has build issues because it's the last synth I'm preparing for the librarian. So I'll have a different route there.

On Dec 29, 2021, at 10:52 PM, Chris Pacejo @.***> wrote:

Hi, a few more fixes for the D Station. Also a build fix for an unrelated synth.

You can view, comment on, or merge this pull request online at:

https://github.com/eclab/edisyn/pull/46 https://secure-web.cisco.com/1W6sAK2LMwrsYHdrnO24BXKXTeowzE1ZcW6JaG5qDRSAwbdxWhj_i5wQP52Zyfeeav7Qc2J4vK4KMM-Nd5CXSgFPg_1Yd1FcyZ3zgL9fHA1NfAfga_VfKc51w7D8QvOA4gzHxsL1RYhSGpbsPa3tqsyLusez2DIEdLyGh82PN0ITrp5TPwZKHs5p2K2WnVbFWgqYlx1xvLuQn8vhLyO6JtugVPtjH8393spgVCnR8HpT4zlqU2wrBefur8Y3o3TjDVRXcOKkutw5jebAh-KTPCgrDHMK_zeZoXbX0yXmNxqNKw-qS5frX-UNGg3IqMzMakifxrf2uBex_uTK0La9j1MBcaVRHPO_Y5jkgNPCDoRPCgo7QqyV17_fhfSgFWBa8dOA5ihZGY2Ty2JkBw4F9MqyPJA0lfGi1nOVrf0J5amPt7FXJCGhbyzGGHXCY8gp-/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46 Commit Summary

0ef00cb https://secure-web.cisco.com/1rgFcDy3nDYTDvRKS-Q-RulUXEPNbMmmjnnfBFL1lzfPiZKt2mOexRfXx7gV1RiKQmHEVPmXsmKYBnG3Gm6s7RtDTshB0AJ9mM1ehmf9ruBxTfqbmo9W9kN-Ho6RWsaeIsb2bInKItz5tkec27iEHHLy94cH-tqRvyLlAaf_aFhqw2uT9zx3uc51Ag_AzNvE98TAU63JtlxAQRW_RJ4Z0cvUyKnGtjbQfmCHOvHqhVHTTzOtGsnaEnE4HjyIY8qaPzWz7IPh7sytc79j9THj7pZDG9mUmys0bXW0Yq6zt36soUkHxy1IdbNABjZqDnLGWHIMsA_RsAM2bBR4MsKuIUL9FQeEflSk_W_nXgsso90ptVfZM6qCKfPWvEJv3FUKoRCJc1dpQse_tgbQZE1TzyJOj6o8DPJhrCmQScSQErzRr-WSnTnDOrQgSI3msUaGO/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46%2Fcommits%2F0ef00cbc2e93cd4455bd359512d05838f5ec3ccc Novation D Station: remove unused OC drum type e244849 https://secure-web.cisco.com/1wjEcYvNHO70Uq2-fow6EvvJQPvgDdnsAwVf4-28BCK9n0M0Hf975iDkUpWbboP7HZl2lkYNCG96gfpoLjRh-W9Pp9vTXMF1fEeY1TL6U9YRnYrgijqiHED1-vOmzOk5sLwYAISUedYPmMeCi6yPpwGjZjvNxf6DPUsIYMZZLIThPOBn72_MQ4WwqdXMnv9re0cyr2VVyJqqyFdijMzY3cpYxSv-3BEDr5H5G_NeYUzO7t1Gj_j0lH0AcrG4w4v5DLeLWd7gJUfxagzUnvaBVEFTip3yGUpKQmtJcdj_OI_FP_gAIkzEoPVH4oatxtzvaKo1nEeaGyiTGtN3nQUWx-m5G1NRzIxPVht4ui8F5mGkxWnkGkhIyFHT9-vjeAifAl2WCvkQWSG-7L9rzHZpNBNTxcXeY9_shIe-6DAyMPigs29vNszTm9gMywrWr_Wvt/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46%2Fcommits%2Fe2448496ccbf9a5658c4a64c4d113b8c403a8652 Novation D Station: fix naming conflict of Hand Clap and High Conga 2471718 https://secure-web.cisco.com/1--KEa1ZIbuG6z3Z0zXzv2OV5Rl17UVd8lGmeTPMJgPz1XkW5Qd3hM9hF92A7L3Fg0XT8Rb7A0ZC9XwPJxQGaZOCI9xsNbbDU9Q7u-6PsYSuWRLM1kCXy5v7PdJXWnp_l1s224Y2g8OmPnla2gpoAclNZ4uTpC05-QYXlaz61yT1ymfY7LlxiAJXGCd9ia1AJLLBiz6EPPtG-SPpJzt6UpaEq25AmPvH2imMD4KFPXEZz6-u6a96UoKj3hnKVxT5sqsk5SrvPCHruGtgKD1XE_0gbR4hFjrM7Rn0VZIh2BI4QFDTMJZYJ1pUCYs4fD-_rRsfGpuEm_7WAZS3ROkeSgB7MauKKAwM4Niw7y0vKRDrPW0KupUV72lYCDE2U4xz1RaglzbUmof_Hv_wAwmnw8F4NhL0K66BQdUlxL40zizHO6HKnK9pf1WJuNiB7HdXj/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46%2Fcommits%2F24717183a10115d3452020630a2b424d32ba7f5b Novation D Station: fix bank select order ac6c51e https://secure-web.cisco.com/1hSarE297UXJyHniZFf7jaD3tFyYlThkRhrDHEzmey8Gm42J3hoadxtPPipALD8fMBTyHxlYqpa8MfhkT8_2tqI8Pae1LKwXXldBa5N8kxflv7CwvNhXIDLGUpGWlTJxfbolMnbliArVbEPHlKa5SVfv5geVZHEqZ0oOFPCyaOoLTywM8oT1_mgIYgDjgKMa63R-dT58jwNWYV1b9vApRYsRjNofhxZXWcstImiB8sv5w8YvGjjzyBViMvWgrTNUU8A4TDl2w-ot6eU_73v_vfCUWXrlBH0qcVjAbWFK5Qd4ygKZP007tLqnjL8EOup_cNFXxeJlPMT-DCZdV3sMKGxXiWYaJZBwcn-Kc9VfF2WDL4MaJiUSuTWIOKI_Y_9gNhtihjKCbCGpPP1qEcGGLKGONtraCaAjrCpY8H5Z_tCyVRALZbUEjLa5VO95moD6u/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46%2Fcommits%2Fac6c51eb5e8bdfba8a9c2a1f058b7560bc3b746c kawaik1: fix build issue File Changes (2 files https://secure-web.cisco.com/1UCJDLeFRcVgZVcqhx4ReK_0aTrNzfCixUU0-0Hx5ZI9-uGIknq-NzKRVqEllhKJa3YF-xlT8_agY_ZIg64Jwiq8c3t2mk4YVJvbzHi0UDBXH_f__-2MHAlw5WZYYJ0Ry9KinJcw_ONQ4iXMnNHzZUjZAp-hup37nqV6kOsONtjiQYRl3qi2KxW-Uoa21e199cymp1w1qQJO9QfBbAe1tWcIPBXqmBtPhFICf_sxAguEfBiOIPxOCnDPliHbkyIhRVV-N383yA4184HL9KEKO6KumPQgLh6I6RpBOzp4LFA_avlICSGpWp_jzQndozWz6ph3JtNB6e7kVGOLNX1DddaobmJcNF3uCyVgdxYGfGRYNLququ5Vxarw5WUb_yieaAGJtVuyH_azDIJ8PCDSHSdd8LzUkVcqTWh09PaS7vMzbqcmp_qfIJC8QYwxFCnV0/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46%2Ffiles) M edisyn/synth/kawaik1/KawaiK1.java https://secure-web.cisco.com/15_1zyezn-N7YmR9n-okL0ngFvEWBWpO5Vv9VC7g4RGG-02DQALa4s-9rNEiEkoxLrdaUsOOOvgOXYEeUa3mMKV4uq4s90M10hscERunpnQy3_6LBKJ7YVnw1rzKmXYUboxjDbHOjOAUHQBewO1YgBkFf2W9UK80qi4cYXi8AIaLy5sn4O40yS5CNQ3CsK-jnUIxCsyqlrFdXm3DyiHyhp2LPP7KttlrHVRSNGQ_Xd6_KPWZx8izHB81QFRMKdmTk1yKnFHT73zCnaiRFwjGf60qCVN2_vByndGsmQK467vuK287R3VTNNOPXhPP9hmm9U53jseDdTsfgZuowo5nn8I-pDlmmOWxq7cwe3o1zOVajbLs-71ETcr-CJ5CponHteYtjazMrFKPoAcnS7iow634Ohm0OjTTau333bnUhNyLblVkdVeje9phf8msgUOVk/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46%2Ffiles%23diff-35814f81b7de0aae2b0a8489931fe655cfce34b3cad3621dcdfb2e2d1e2e7dac (2) M edisyn/synth/novationdstation/NovationDStation.java https://secure-web.cisco.com/1IghA-C6ShJrYmb4sXJ5CifzgQvw3h4TEk1ZGSd6QAxmNw3wNW-OkDhbCyNAN52w-rO3ovAEl1V7NFHwRQxOMyDI0HOOnEaVjBg3rN-3EcqkAXhD6WZOgHUd0X95UtZz_z1l3SNZQmlXL87wIP6pA2XCFfXu9BaF4GXISv-jgRRbkc0aaS4qLNLOLCisqp-pRoONLazttGeFDUQ1tTUEDLvreF2mrFRH4cLMLFZ2A297bSR9FBBYJgI5U-P9x8M7513FwISfWbRSfz0BqT7QFuFdVQpG1GXl5b54Z2XW70eMpuKHz9dHwCs_8SzHiRNp4uZRJXZW-4aXG02_kjPKFRzHxr0jWKG1Q8xd-tyoP2VcPSjVy-2fzXstMVFR4ghepih0xGHJHaJOmyeJ0_gTXNK_IUWSqyOqmDa2Q9Xb76EYEl94zSiqX2yRm1Xdgt-KQ/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46%2Ffiles%23diff-e14f8064a5109bd66ec84d4d663e39c532bbd914f85bfc6678716402d7c27fc3 (146) Patch Links:

https://github.com/eclab/edisyn/pull/46.patch https://secure-web.cisco.com/1NyCHRm8ve4e2We1v7lMz6rZ5QiqXMdKiKpW2gC-N0yR-t7UWThDMVNdikYHI3FrxcXbv1PiF-Urov1dQHcj7iI4Ykp1vJgpxAzupM22cuzcIgPA9lGdpUNw9Yf5velqhkAu3D3XnhW0MoSU82-dU_7DsikMLQ1vmuAS_6KD39uHI7vo9XMjzyfDG-GRx2ejJx6rwE3hHLmhSdM0tF07WXR_A3-uE6WBE2EOaf1_wg97F2l5aiEeGNywvs24Ug24JgNYth_AWGYbAkPiEGWCjpQFyOcdRCT149j50xInOnDPeGsIo3SbZNxFpBqyWd2xghhcLy5axbJFSs6pKTZq9cR9aacKQIYkmfl9r5saF_dcDQ7pujTs_uEVUT-JpV4z7u_UVw40KQ2Rj3qYcZ-3tx0O_JlX4ah8ubW0YCvkpz-71FkePjR2cvla668IzrDkj/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46.patch https://github.com/eclab/edisyn/pull/46.diff https://secure-web.cisco.com/1feGWop5LLQVD437uJqa2KOadeBQBUj5ET-HBhkjpqTpLNRnEobpYi2rZhzkFcel-4m-LSP3rG124E6kEfVweCO-K-tSXHGZl1BL5ZnIwvrklfetGw5wgpDaKIm640BBzeXwSj6wAOSEy_jLg2Ma3IotsCZ7pnPmVkkGt_TW9RSQwB5JpEo3Ln7LkFMPZGpVYY3N38n4TQ1h4L0QtSCL_Bmz3l7VFSdMmVRyg02WWPGrdQlIk_3K1dwbYeJF6adhcg5xIMDA1_KsJMDxtRpEfBScWn9_B5qYB7Wv5PtTcUsmdhcvrYyzOTCmIH4-LlypG7zvlwWLRfhUxZHRHeQwu4WvgLtSw95kURbCSRkGH1mkDl359zKNSEe7bZM18gUx2lH8S0Ab5Y85xQZtXfufVsb4iiWbArWVHRCFunHnnKG7VomajnB4w-oSJA2MMKB1G/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46.diff — Reply to this email directly, view it on GitHub https://secure-web.cisco.com/1W6sAK2LMwrsYHdrnO24BXKXTeowzE1ZcW6JaG5qDRSAwbdxWhj_i5wQP52Zyfeeav7Qc2J4vK4KMM-Nd5CXSgFPg_1Yd1FcyZ3zgL9fHA1NfAfga_VfKc51w7D8QvOA4gzHxsL1RYhSGpbsPa3tqsyLusez2DIEdLyGh82PN0ITrp5TPwZKHs5p2K2WnVbFWgqYlx1xvLuQn8vhLyO6JtugVPtjH8393spgVCnR8HpT4zlqU2wrBefur8Y3o3TjDVRXcOKkutw5jebAh-KTPCgrDHMK_zeZoXbX0yXmNxqNKw-qS5frX-UNGg3IqMzMakifxrf2uBex_uTK0La9j1MBcaVRHPO_Y5jkgNPCDoRPCgo7QqyV17_fhfSgFWBa8dOA5ihZGY2Ty2JkBw4F9MqyPJA0lfGi1nOVrf0J5amPt7FXJCGhbyzGGHXCY8gp-/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46, or unsubscribe https://secure-web.cisco.com/1aY2-TwNBzZUt24RttyW5ye8glk8WQyo1cDYXvnZfVwkOqgS44ePdp3QkYGZVBh12HtJ5_JyZB9bXTkTyUs9kkrF6_8-mdr58omtDhYW8rcqaSYWKJnEy0QIaJMSFVc2YlavIFuH4H8j-H3q-ZCIU2qrnFRetHkjx3VlgDujdflkB2AKmW2qQJQAvPSd94P9bUu_22FbNDWAWPExf2I_tU759EBwxjYu3TtZ7seD_lNxMG1Sz7Evd0RXpM0DXAhXKJrc5qpFC4aiPe!%20TqZU9jM3eA6SAE5P7-cQxl-1oIGvetcg_Fkp0DP2b7g91Pf4JKHjUSJruRG8pgBBZwFsUA3IA8MiqI0iEt9f4lfR5G37cXgmqISzMtfHz7XMjjQLfbaYtIPBu5fEEOhWNgQDCImookGXqe_5Mv5C4Fp2IG6PrW0jKR-sIKwp1IminHsW2lC/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADAZDVABIMBSDIOSZVK3CTDUTPJOZANCNFSM5K7AX72A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread..com>

cpacejo commented 2 years ago

Ah I figured something was up there. Want me to drop that commit?

eclab commented 2 years ago

Drop the K1. But tell me more about the Drumstation changes you're making.

On Dec 29, 2021, at 11:04 PM, Chris Pacejo @.***> wrote:

Ah I figured something was up there. Want me to drop that commit?

— Reply to this email directly, view it on GitHub https://secure-web.cisco.com/1JhmIHsoTi7aq5xYoRHiKDIbAyi1BEWlBmzmLw1NwucQjDv0kn3Ah-xjHosz3NeBuNidHWJDbT4Ci0SUMKCkLA0f5c6mRPM-nLaPsi-pmhDvErRe3UUqDfF65amBxzPltLFGVQ2_NgxufgCYqHbcP1x0rjmPMZZyn8VJvPkb5L1pDc19OTnMdK741suh2jD2FAyTsfOzCiM9jeP414MP36EPKu3OV96pWfzo0bQL47NRcc32ZC6I9s3TxY5LgmzHKYGbge6efFCIQ6O4irxZpQ59KmK8IqodNhW3GLrG1aoFh3sorab7ZKaeSmt4mYpPXlqZZwM2HZ44EkR6Qaf8qV-HjsizTVXIqXxpFSEZmlTiOHnF8fVyvcH5427pduG6RGdpfKEJLnJPBo369fnp9oSdFNBXZvE-lTXT96gJWPCxzKWxHLTMrIIQqTbXcsTZ1/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46%23issuecomment-1002863118, or unsubscribe https://secure-web.cisco.com/1U7R_tDekCnTKALGmrtayyZ8LcCXggxDNvZfW2nqACKS7SMw4D7QwNsPKZ_mbMIgBRbbghECcMPSpV-vYJISqr-CVxotsYVIcM5hDN4AkLk2GPrvKa9peAkxqhcHLz0sk_h-ZgxyNIIVig12-Xkd3US1SXH6V5SnQwYV2rQIW-2V7kPJe5FlJmeo0xvZI7limD-V19GgJHQxwxZwjkVbp0TJmVHleDMez0w9H1ZsEiEZbidN9fUs!%20n7UIBHLwzAOfr_WTeYSf2kU1RKntqkB8_FvxJiCgPCLGyJ1yFeAPgdE3X5yz0BCly8DP4s_ZEErhmjrCOwPxk_7imNMP4yKZmLNZaRqZLy48NjngECy48S1sa-MitUy0cM4GMcfffEv-08YjVB_cJn-QKeAqQoPqmdKgu003qbnp39agMfHUBrB0-z-kCNvPWS_A_YrVhx-PR/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADAZDVCBZR554KS2Z2K5MJTUTPK3PANCNFSM5K7AX72A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.

cpacejo commented 2 years ago

Done.

"remove OC drum type" --> this is dead code, there are no drums named as such in the class (or in the actual Drum Station for that matter).

"fix naming conflict of Hand Clap and High Conga" --> both Hand Clap and High Conga were referred to as "HC" in the class, which resulted in changes to one being reflected in the other, and vice-versa. This renames all Hand Clap drums to "CP", which resolves the conflict.

"fix bank select order" --> the numbering of drums for the "bank select" configuration is incorrect, causing D Station sysex files to contain the incorrect values here. (Namely the 808 and 909 drums are swapped.) This just swaps their order, without changing the order of the drums in the UI panels. I've confirmed this change against an actual D Station.

cpacejo commented 2 years ago

Side note -- it may be helpful to add a Git tag when making a release (e.g. v29 at commit b49d1550) so it's easy for anyone building from source to get a clean build. (I couldn't find that commit at first, hence why I bumped into the Kawai build issue.)

eclab commented 2 years ago

I wish! I am, believe it or not, using svn via a bridge.

On Dec 29, 2021, at 11:28 PM, Chris Pacejo @.***> wrote:

Side note -- it may be helpful to add a Git tag when making a release (e.g. v29 at commit b49d155 https://secure-web.cisco.com/1UF73HNE4sQkP6-hhuloumeT8JVJ_UFjlvlOWBPjLkIKnVLMnfey83foe-b0YiYdCMFN2SyqwrqxpKyLBDh8SixlheszvZ9-DULxdN0D80vMm_aF9KssP2JWGtksywrM4bq1uYuWykA4h9iE7Rrc0LbeMo49Cf-IY9BmArQMu-4buMuvZSQ9XA1E4HgcdJk23oSgg6nfaud_DNWMfvRR4h_4a0eNzLoXlfSmJp1UBL4uth-4AjgaA6aZm3fHeSZ3ghitwUFK3OvbamxC6N_S-i1kIPvg630T-eH6ZCiafFljBGZekUSxKwHXERsBtTSuxpyRyUzP-SIIzLqI3FEk9nk1-YXebYrYZu6bPeFyRhkZvG7CnB3Flc788MqXwagZfXpt8jp6vc54KIe8BT_nYJE9hahmVuR164Iikuwzfoi9iBBEFGWrshhk3MdG3MrmV/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fcommit%2Fb49d1550530481e9e8283de9ebe308c3ee7be7a5) so it's easy for anyone building from source to get a clean build. (I couldn't find that commit at first, hence why I b! umped into the Kawai build issue.)

— Reply to this email directly, view it on GitHub https://secure-web.cisco.com/1ax3xRCJj45d-YwWlupaA68-HW3vu3DqfbTbfQp-GXOd2o7LahUmpNBOxcz822mKD_IUPF_ZXutet35TRACD1pWcvyWwCZQCT8b6PwOabzqji4FdfQ5P_tqVx2om-LV5hRGdkvRT5HHAzzsh8SU0xRa_5nkfvbB3Q3Cy3WUpK0RkzEKrcT9QCjQ3PvRy5WYn9H5ILZafyhFoG4aaCfzvE0iMqqTuB-Gx8pO2Sl-OeGpabZAFMy3mA2pM9ADPepHV5VeFef8iS5ZABGyFRPNDZhz1vy2QIqZtHbnwZQQCwjPsEG5aIYa9fAfmtq818QATKwp7NF_cx8ZqbfQ6vNhypmPojq7un2xgtT8rPL-QCH9pt8CjYpwIq31N3XKHYLSt1Pizd-aRKPViQm__5Ow1DMcUQmBS2pCsqVRUiqdTdZE6aa_0qWgef6VZB9ENOZURT/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46%23issuecomment-1002868584, or unsubscribe https://secure-web.cisco.com/1KPvCXdAsVU_npo9NBH7fdDvyC0v_DC8sDE5gW2imw-AVE08r02D4UVlGfjmLof-gN733zgFTsu6-nFKdrqzVSbmTNboBEMN6U1pN_-Uz5btXoSYwfBtJJ1zyEDZQsWIaGXcBPlxS-M9Iice3LXdx5Hw-mIbzOmfju0cKc9QxqE8j7FuJewAW6b6SM79NBtoBubFiGQcj3Yrs8R0p-u4kW9IN46lV7S7OrabFWiVy8i_ua8n5ljD!%20oZXJB0wqhAOQ7_8XS2vdAWDZdqwAureNzw1voLnlyyiCAG2tver4GgsWMyzMJS1fXkx3nm_M9WitLynqa5AxNWLewK9rzvsJtCcKE2xrzHvS-luFwa45-1cB6n8GVMYMnIX_HVFZZLFzhJ7Wa2gFMew4sj7t4liTHOWcfR0ay3fae8WU5KfTSMTqnz7Agawj1pE_clrvwaexS/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADAZDVBLZGJYRDC4UBOFCOLUTPNXRANCNFSM5K7AX72A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.

eclab commented 2 years ago

So I'm looking over the changes. OC is dead, can be removed. Hand Clap seems correct, should be changed. But I'm concerned about the bank order. Understand that the sysex document is one I reverse engineered a while ago and I was pretty sure back then that the bank ordering (Table 6) did in fact have the 808 first. MidiQuest seems to have 808 first too. It'll take a while for me to verify this as I'm knee-deep in librarian-building. In the meantime, can you present anything convincing enough to make the change preemptively? If so I'd trust you.

On Dec 29, 2021, at 11:18 PM, Chris Pacejo @.***> wrote:

Done.

"remove OC drum type" --> this is dead code, there are no drums named as such in the class (or in the actual Drum Station for that matter).

"fix naming conflict of Hand Clap and High Conga" --> both Hand Clap and High Conga were referred to as "HC" in the class, which resulted in changes to one being reflected in the other, and vice-versa. This renames all Hand Clap drums to "CP", which resolves the conflict.

"fix bank select order" --> the numbering of drums for the "bank select" configuration is incorrect, causing D Station sysex files to contain the incorrect values here. (Namely the 808 and 909 drums are swapped.) This just swaps their order, without changing the order of the drums in the UI panels. I've confirmed this change against an actual D Station.

— Reply to this email directly, view it on GitHub https://secure-web.cisco.com/1i8xO7CwbULCvPYDlbTynooYLWpsjQAgN6xJGP_rfAoCOs6Zl826vPAcMGwmuQW5isfXhZ8wmblrtFq0DhaqXKKnDEa8_XlbK-1ov1HdDWjrgbB9ViqcysP8CFPXztxtpmMYTUq1NDNj7_O1u9BT9ZClAL2yINbMNH1rn-uJYo69qqWVsbqXgdqi92zalD5oix1GRC2oAh2Yh8QwN45B16A-nbJodIyUqhT-BYmZ4m_f9ussO7gi2UMNM1B58wO8UkdAG0tGf4GxSbyrYVmCcTMEl1oA3g3uVhsSpChDq8w5FWMvEMEUGOQqMvCk3jho8ahPb6f_Ekn4J_czvduzgim9eXHiK4hU83dAqqDEf1z2OtmdbHukX3zCPiEtPA91N5XvvpeLrzDkLOrbrGImAI8Q_mQPxpA00HWJ3izbcfO9a175vfMbDAK8x6AuD6M22/https%3A%2F%2Fgithub.com%2Feclab%2Fedisyn%2Fpull%2F46%23issuecomment-1002865911, or unsubscribe https://secure-web.cisco.com/1lO1Vw625K_r1B4fhtV0oFEobJ0GcxxwXfXI41WY12M9zIAls8fDZ7J-YSF4nWOEXEl-rrG0GR6m1i6DXGb3rf2YAwzGMbCOwEfmwY6myvm7z8z0VqZmsv3Ienm-qW8R7lm6OIFTyXiYPxklmzZcMjgFhIuwznJO8WgJDz4IbrZHUycOIz6oOxsuycTdwnGszIrGS7sta0T_NJJeTKdsphNucIEz-nU5F415rXuLO7ocCOFGuGYm!%20cuwEPqEbe5yEpHzMdBlL5DblFNXYwwwn2JrtsehXvgh3YufFEVFOBS7KTOqTgRwLyiJmxQyP8ZYUTVkU0BgaltTBZvVIgDtV_AipOxBya7sPZlXTa4iuSXRk1wljyYNg_UGn-pDMjkB5jWARqv48J5F_9z8ud5s-KrbCvHcLBuudbrHOe-ljdeKJDeuTSQxNyq02HQ9AKHoqO/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADAZDVBSEF3EDGEHALH5LR3UTPMQ5ANCNFSM5K7AX72A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.

cpacejo commented 2 years ago

I dumped patch 0 ("Classic TR909 V1") from my own Drum Station. Without the change, Edisyn lists banks A through D as:

Which do not match with the banks as reported by the Drum Station itself:

However, with the change, Edisyn correctly reports these banks as:

I tested this with several other built-in patches as well, and also by loading my own patch which I created with Edisyn, for which the banks did not translate correctly without this change (and the wrong sounds came out), but do translate correctly with them (and the correct sounds came out).

If you own a Drum Station you can confirm the above for yourself.

I can't speak to why MidiQuest reversed these. However, some of the drum names line up when in the incorrect order, just with 808 swapped for 909. And the order as listed in the manual lists the 808 drums first. It would be an easy mistake to make, to assume the drum numbering follows the order listed in the manual, and check the names (but not the kit) of only the first few drums.

eclab commented 2 years ago

All right, let's do it.

cpacejo commented 2 years ago

Cool, thanks!