search

eclab / edisyn

Synthesizer Patch Editor
Apache License 2.0
551 stars 51 forks source link

Missing Pitch Envelope Sustain Level slider in D-110 editor #53

Closed 02FD closed 2 years ago

02FD commented 2 years ago

The D-110 editor is missing the Sustain slider in the pitch envelope settings. It will always write 0x00, which corresponds to a level of -50.

This leads me to conclude that the editor was tested with a D-10, instead of a D-110, which probably eased accessing the parameters. The D-10 (according to the midi implementation) has a "dummy" value where the D-110 would have the sustain level. To maintain compatibility between both, it'd be best to write a value of 0x32 instead of 0x00, or include a slider for it that wouldn't affect the D-10 anyway.

SeanLuke commented 2 years ago

So according to the D110 sysex docs, the D-110 pitch sustain level is always fixed to 50 (value 0). On page 117 of the D-110 manual, in the section "5-1-2 Partial Parameter", it lists the pitch sustain level as:

00 12 0xxx xxxx P-ENV SUSTAIN LEVEL 50 ( always 0 )

Note that this is "xxxx...." whereas other parameters are "aaaa..."

On the other hand, the sustain level appears in the manual as an option. So what gives? Send me mail (my email address is on Edisyn's manual front page) and I'll produce a beta for you with a sustain level dial, and let's see if it does anything. Note: I may not be able to do so until next week (I'm on vacation).

BTW, I have never seen a D-10.

02FD commented 2 years ago

Oops. I pressed some buttons. Not familiar with github yet.

Anyway, yes, I'll get on that email.

SeanLuke commented 2 years ago

Per offline discussion, I've committed changes to include this parameter and things appear to be working, so closing. Changes will appear in the next release.