Closed csdaw closed 1 year ago
Hi @csdaw, is this pull request still open given the latest (#64)? If it is I'll merge it, otherwise we can close
Yep @eclarke, this PR is still open 😄.
For the 4 conflicting README image files, the files currently already in eclarke::master
should take precedence over the ones from csdaw::refactor-quasirandom
which are out of date.
Hi @csdaw, apologies for the delay in approving this. Since you've been a huge help in replying to outstanding issues and contributing code fixes, I've invited you to be a contributor to the repository. This should make it so that you don't have to wait for me to approve/merge changes, close outstanding issues, etc (though of course, please don't feel like this is any kind of obligation!) Thank you for all your work so far, it's tremendously appreciated.
Hi @eclarke, thank you I'd be happy continue maintenance on the code/repository (and in time prepare things for an update to CRAN). Would you be able to re-send the contributor invitation? I've been a bit busy the past few months but things are clearing up for me now.
Just re-sent!
Hi there,
Here is the next PR, this time for
quasirandom
functions.Changes made in this PR:
geom_quasirandom()
, thegroupOnX
argument has been deprecated. Axis grouping is now automatic by usingggplot2::flipped_aes()
internally.position_quasirandom()
, thegroupOnX
argument has been deprecated.PositionQuasirandom
has been rewritten in a similar way toPositionBeeswarm
.offset_quasirandom()
has been created and functions in a similar way tooffset_beeswarm()
."tukeyDense"
or"pseudorandom"
methods which are highly similar.Addresses #49 Partially addresses #47