search

ecleese / plexWatchWeb

A web front-end for plexWatch.
255 stars 41 forks source link

Do we need to show error message if it fails to retrieve metadata? #158

Open iAmMrinal0 opened 8 years ago

iAmMrinal0 commented 8 years ago

So I have PlexWatch running for quite some time and I have moved my library around many times and this resulted in the media ID's to change which means in some cases it will always try to retrieve details for the ID which has since moved to a new ID, so no metadata.

As you can see in the screenshot, the last item isn't retrieved and shows a failed message. So is that necessary? Or do we take the approach as it is in the master branch(see screenshot), i.e. not show the error at all.

dev branch screenshot 1 master branch screenshot 2

Arcanemagus commented 8 years ago

Personally I follow the approach that this is a client for the plexWatch database: If it has invalid data in it it should be fixed there, and in the meantime we should simply report that to the user.

The master branch isn't really handling this nicely... it just isn't handling this failure mode at all.

If somebody wants to create a PR to handle that failure in a different manner I'm not opposed to it, but as far as I'm concerned this is working as intended.

Thoughts @ecleese?