search

ecleese / plexWatchWeb

A web front-end for plexWatch.
255 stars 41 forks source link

stats.php line 242 #172

Closed trackermb closed 2 years ago

trackermb commented 8 years ago

Hi there saw that the maxhourly plays chart was pulling DD MMM on the x Axis this can be fixed by copy line 214 and replacing line 242. Finished line should look like

return moment(x).format('<?php echo $settings->getTimeFormat(); ?>');

only issue i am having now is that it doesn't sort the hours in chronological order it just adds any new hours to the end screen shot 2015-09-30 at 12 20 40 pm

screen shot 2015-10-02 at 20 53 21 as you can see theres 2 10pm's

Cheers Mark

Arcanemagus commented 8 years ago

Which file are you talking about? Are you looking at the dev or master branches? The master branch is very out of date if that is what you are currently using...

Arcanemagus commented 8 years ago

Ah, or I can read the title of the issue :stuck_out_tongue:. I'm assuming that you are on the dev branch based on the line numbers.

The tickFormatX only affects the display, not the data so it should have no change on the sorting order. Your screenshot shows things sorted chronologically though so I'm not sure what you are trying to say here?

trackermb commented 8 years ago

Hi yes using Dev branch. What I mean is the chart should really start at night and have every hour regardless of an plays.

Also I'm now getting this duplicate entries for a few hours.

Arcanemagus commented 8 years ago

Unfortunately the graphing library cuts out "empty" data points from what I remember of the last time I looked into this, so having it show all hours would be difficult at best, but probably involve switching to a different library.

What do you mean by "duplicate entries"? More than one entry for the same hour?

trackermb commented 8 years ago

hi there i have edited 1st post with new screenshot

Arcanemagus commented 8 years ago

Those are different days :wink:.

trackermb commented 8 years ago

I thought that the max hourly plays would have collated all play @ each hour for all the days, so you can see what time the server is under the greatest load. Is that some that could be edited in a future release?

Arcanemagus commented 8 years ago

That's a great point, the chart title doesn't really match the contents. Feel free to submit a PR (to dev) that fixes this.

Personally I would recommend looking into PlexPy as it has several architechtural advantages that make it a much better choice for something like this (namely being run as a service instead of a stateless PHP application).