search

eclipse-4diac / 4diac-forte

Eclipse Public License 2.0
31 stars 33 forks source link

remove raw pointers for RData and action info in opcua #115

Closed cochicde closed 6 months ago

azoitl commented 6 months ago

can you please clean up this PR by not having a merge commit in it. I typically recommend to cherry pick or interactive rebase the required commits on top of origin/develop. As I tip also to not use pull but use fetch. Pull often does auto-merge which can lead to unnecessary merge commits.

cochicde commented 6 months ago

can you please clean up this PR by not having a merge commit in it. I typically recommend to cherry pick or interactive rebase the required commits on top of origin/develop. As I tip also to not use pull but use fetch. Pull often does auto-merge which can lead to unnecessary merge commits.

done! I thought the commits are being squashed before merging the PR anyway

azoitl commented 6 months ago

done! I thought the commits are being squashed before merging the PR anyway

I'm still trying to get accustomed to the Github workflow. With merge commits in the middle I still get a bit nervous. I also not always squash before merging. Especially when I think the individual commits should be preserved.