eclipse-4diac / 4diac-forte

Eclipse Public License 2.0
26 stars 30 forks source link

Is there any consideration to using human readable time in DEVLOG? #99

Closed kumajaya closed 5 months ago

azoitl commented 6 months ago

So far not. But I like the idea.

kumajaya commented 6 months ago

So far not. But I like the idea.

Sir, something like https://github.com/eclipse-4diac/4diac-forte/pull/100 ?

ernstblechaPT commented 6 months ago

My 2 cents:

azoitl commented 6 months ago

Yesterday, when I first read the issue, I had as first idea to use NOW and the toString() Method to get the Date_And_Time's IEC 61131-3 literal as representation. I only was not sure about the performance implications.

But before we continue here we need to get the Zephyr code out of this file. Otherwise the code is unreadable.

kumajaya commented 6 months ago

For the meanwhile, I convert the PR as a draft.

kumajaya commented 6 months ago

Yesterday, when I first read the issue, I had as first idea to use NOW and the toString() Method to get the Date_And_Time's IEC 61131-3 literal as representation. I only was not sure about the performance implications.

But before we continue here we need to get the Zephyr code out of this file. Otherwise the code is unreadable.

No issue for Windows, Linux, or embedded Linux but not sure about resource constrained device. For Zephyr, it does not use the standard chrono time functions.

kumajaya commented 6 months ago

Add switch, optional logger time in IEC 61131-3 date time literal.

kumajaya commented 5 months ago

PR https://github.com/eclipse-4diac/4diac-forte/pull/100 has been merged. Thank you all for the great guidance.