search

eclipse-4diac / 4diac-ide

Eclipse Public License 2.0
15 stars 27 forks source link

Correctly show varinout in typed and untyped subapps #210

Closed azoitl closed 3 weeks ago

azoitl commented 3 weeks ago

With this change the interface bar of typed or untyped subapps shows on both sides var inouts.

Furthermore the filtering of varinouts now reflects the internal connection state of subapps and only for subapps.

github-actions[bot] commented 3 weeks ago

Test Results

    94 files  ±0      94 suites  ±0   42s :stopwatch: -1s 27 159 tests ±0  27 159 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  27 160 runs  ±0  27 160 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 45a417d5. ± Comparison against base commit 2814359a.

azoitl commented 3 weeks ago

I see some possible positive changes in performance, but I would like to know why getRemovedVarInOutPins is replaced into SubAppForFBNetworkEditPart.java

As I tried to to convey in my commit message. VarInOut Pins should only be hidden for subapp instances if they are not connected on the inside. However all the code for showing hidden connection labels is in the AbstractFBNetworkEditPart class. therefore haveing a basic implementation in AbstractFBNetworkEditPart and a subapp specific refinement in the SubAppForFBNetworkEditPart seemed for me the best solution.