search

eclipse-4diac / 4diac-ide

Eclipse Public License 2.0
15 stars 27 forks source link

removed the service sequences from five io files #235

Closed MoritzO02 closed 2 weeks ago

MoritzO02 commented 2 weeks ago

removed for QB, QD, QL, QW, QX for issue #230

MoritzO02 commented 2 weeks ago

There are also some more FBs with service sequences in the subdirectories of the io directory. And around 40 in other directories. Should i create pull requests for those too?

github-actions[bot] commented 2 weeks ago

Test Results

    94 files  ±0      94 suites  ±0   38s :stopwatch: -3s 27 159 tests ±0  27 159 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  27 160 runs  ±0  27 160 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 43e403ad. ± Comparison against base commit aacd6b16.

franz-hoepfinger-4diac commented 2 weeks ago

There are also some more FBs with service sequences in the subdirectories of the io directory. And around 40 in other directories. Should i create pull requests for those too?

@azoitl here was a Question from @MoritzO02 ?

Thanks, Franz

azoitl commented 2 weeks ago

@franz-hoepfinger-4diac: The same question was asked at PR #236. I hope answering once is sufficient.

diplfranzhoepfinger commented 2 weeks ago

@franz-hoepfinger-4diac: The same question was asked at PR #236. I hope answering once is sufficient.

of course. @MoritzO02 is quite eager in committing, i need to speed up to follow.