search

eclipse-4diac / 4diac-ide

Eclipse Public License 2.0
15 stars 27 forks source link

removed service sequences for 5 fbt files in utils #236

Closed MoritzO02 closed 2 weeks ago

MoritzO02 commented 2 weeks ago

removed in CSV_Writer_10, CSV_Writer_9, GET_STRUCT_VALUE, GetInstancePath and SET_STRUCT_VALUE for issue #230

github-actions[bot] commented 2 weeks ago

Test Results

    94 files  ±0      94 suites  ±0   37s :stopwatch: -2s 27 159 tests ±0  27 159 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  27 160 runs  ±0  27 160 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 327d9540. ± Comparison against base commit 4bd2f77c.

:recycle: This comment has been updated with latest results.

MoritzO02 commented 2 weeks ago

@azoitl There are also some more FBs with service sequences in the subdirectories of the io directory. And around 40 in other directories. Should i create pull requests for those too?

azoitl commented 2 weeks ago

@azoitl There are also some more FBs with service sequences in the subdirectories of the io directory. And around 40 in other directories. Should i create pull requests for those too?

If you have time and don't mind that I will not accept all changes it would be great to have a cleaner typelib. However I don't see it as high prio topic.

diplfranzhoepfinger commented 2 weeks ago

OK, thanks a lot ! @MoritzO02 thanks for the commits.