search

eclipse-4diac / 4diac-ide

Eclipse Public License 2.0
19 stars 29 forks source link

Invalid name mark in Var InOuts Tab Table #372

Open ShantKhatri opened 2 months ago

ShantKhatri commented 2 months ago

The newly created variable's name is always invalid when we create a new InOuts Variable from the "Variable InOuts" tab in the property section. image

Steps to reproduce

  1. Create New Type
  2. Open created type in workspace
  3. Go to Var InOuts Tab inside Properties
  4. Create New Variable
bwiesmayr commented 2 months ago

So the solution is: when the WITH is missing, there is an error marker It goes away when you add the WITH. This is mainly a usability bug.

MartinMelikMerkumians commented 2 months ago

The question is where to put the marker on.

VAR_IN_OUTs always need a WITH due to reasons on how to combine this IEC 61131 feature with the semantics of IEC 61499. The creation of the error marker itself is on purpose.

bwiesmayr commented 2 months ago

I understand that the creation of the error marker is on purpose, but neither @ShantKhatri nor I managed to resolve the error when we encountered it. We did not get so far as to create a WITH because we thought the tool is trying to tell us that we did something wrong, like invalid name, cannot have varinout in this place ... So some tooltip, showing the error marker on the whole line and not the name, ... could all be possible fixes. The user needs to know what they did wrong (or actually, that they are simply not done yet)