search

eclipse-aaspe / package-explorer

AASX Package Explorer
Other
63 stars 19 forks source link

BAMM rdf Importer - unitId not generated #115

Open BirgitBoss opened 2 years ago

BirgitBoss commented 2 years ago

Describe the bug unitId not generated for measurements

To Reproduce File.Import.Import BAMM rdf into AASX

select .ttl file with bamm-x:Measurement e.g. test file Battery contained in release

Expected behavior

Example:

@prefix unit: <urn:bamm:io.openmanufacturing:unit:1.0.0#> :BatteryTemperature a bamm-c:Measurement; bamm:name "BatteryTemperature"; bamm:preferredName "Battery Temperature"@en; bamm:dataType xsd:int; bamm-c:unit unit:degreeCelsius.

unitId = "urn:bamm:io.openmanufacturing:unit:1.0.0#degreeCelsius"

juileetikekar commented 7 months ago

Hi @BirgitBoss,

Thank you for raising the issue !!

If possible, could you please share the .ttl file, so that we can reproduce the issue?

BirgitBoss commented 7 months ago

the file is part of the release itself: https://github.com/eclipse-aaspe/aaspe/blob/main/src/AasxBammRdfImExport/test/Battery.ttl

However, in the meanwhile there is a new version of SAMM (named BAMM before) and also a generator from SAMM to AASX as part of the ESMF project. So probably this importer is deprecated. Lets check on this before further action. thank you.