Cannot save AAS which has an Operation in Submodel Template

eclipse-aaspe / package-explorer

AASX Package Explorer

Other

65 stars 19 forks source link

Cannot save AAS which has an Operation in Submodel Template #148

Open STUBA-rupr opened 1 year ago

STUBA-rupr commented 1 year ago

Describe the bug After I add an Operation under a Submodel template I cannot save the AASX file, and cannot do check validate fix as well.

To Reproduce Steps to reproduce the behavior:

Get for instance AAS from IDTA 02008-1-1_Template_withOperations_TimeSeriesData.aasx
Add a new Operation to the submodel e.g. Oper01
Try to save

Expected behavior I would expect that aasx file is updated. But it is not the case.

Screenshots

Desktop (please complete the following information):

OS: Windows Server 2022
Browser Edge, Chrome
Version [e.g. 22]

Additional context Add any other context about the problem here.

STUBA-rupr commented 1 year ago

I figured out that there MUST be defined at least ONE INPUT, ONE OUTPUT and ONE IO. Then it is possible to save the AASX.

wiresio commented 1 year ago

And thanks for the hint!

MichaelHoffmeisterFesto commented 10 months ago

In this branch I added a fix: https://github.com/admin-shell-io/aasx-package-explorer/tree/MIHO/TMV30_SAMM_Xmas2023 See: https://github.com/admin-shell-io/aasx-package-explorer/commit/f3cf9337f1668f41735be271eeed068ba3d63148 Changes to: src/AasxCsharpLibrary/Extensions/ExtendISubmodelElement.cs Right now, I dont known when it is integrated to the main brnach.

wiresio commented 10 months ago

Thank you @MichaelHoffmeisterFesto - it is working for me!

STUBA-rupr commented 10 months ago

Thank you as well, nice Xmas gift!

wiresio commented 10 months ago

Should be kept open since it is not yet merged into main!

Ptahr commented 3 months ago

I also have the problem regarding the time-series data submodel with operations. Unfortunately all links to solved issues or fixes aren't active anymore. Is it possible to update those?

MichaelHoffmeisterFesto commented 3 months ago

Hi,

the release version of AASPE is ages old. Could you try my current build? As logged-in GitHub user, go to:

https://github.com/eclipse-aaspe/package-explorer/actions/runs/10107989063

.. and download the "aasx-package-explorer.LATEST" asset and try out.

I've tested the test-case described by STUBA-rupr and it seems to work.

Best, Michael

Ptahr commented 3 months ago

@MichaelHoffmeisterFesto Thank you for the fast response. With the current build it also works for me now.

STUBA-rupr commented 3 months ago

Hello, I can also confirm that in the last main commit with using the IDTA 02008-1-1_Template_withOperations_TimeSeriesData.aasx the issue is resolved.